Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] Adding new module partner_identification_sim_indonesia #1

Closed
wants to merge 2 commits into from
Closed

[ADD] Adding new module partner_identification_sim_indonesia #1

wants to merge 2 commits into from

Conversation

mikevhe18
Copy link
Contributor

No description provided.

andhit-r
andhit-r requested changes Dec 20, 2016
View reviewed changes
Copy link
Member

@andhit-r andhit-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mike kok .pyc nya ikut ke ambil?

@mikevhe18 mikevhe18 force-pushed the 8.0-partner_identification_SIM_indonesia branch from d8af0ff to 3a91d58 Compare December 20, 2016 06:10
@codecov-io
Copy link

codecov-io commented Dec 20, 2016 •
edited
Loading

Current coverage is 100% (diff: 100%)

No coverage report found for 8.0 at cb60f86.

Powered by Codecov. Last update cb60f86...1e75a69

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3a91d58 on mikevhe18:8.0-partner_identification_SIM_indonesia into cb60f86 on open-synergy:8.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3a91d58 on mikevhe18:8.0-partner_identification_SIM_indonesia into cb60f86 on open-synergy:8.0.

@mikevhe18 mikevhe18 force-pushed the 8.0-partner_identification_SIM_indonesia branch from 3a91d58 to 1e75a69 Compare December 20, 2016 06:28
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1e75a69 on mikevhe18:8.0-partner_identification_SIM_indonesia into cb60f86 on open-synergy:8.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1e75a69 on mikevhe18:8.0-partner_identification_SIM_indonesia into cb60f86 on open-synergy:8.0.

andhit-r
andhit-r requested changes Dec 20, 2016
View reviewed changes
partner_identification_sim_indonesia/models/res_partner_id_number.py
class ResPartnerIdNumber(models.Model):
_inherit = 'res.partner.id_number'

_sql_constraints = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikevhe18 validasinya bukan begitu caranya. Coba lihat https://github.com/OCA/partner-contact/pull/298/files#diff-55ffa8353f7b2918117e842a9334d86cR7 dan https://github.com/OCA/partner-contact/pull/298/files#diff-51ed1038dbdf198d833c2475bad80d56R30

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iya mas gue tau, tapi masalahnya :

  1. Validation itu khan opsional , bisa dipake bisa ngga
  2. Validasi yang di contoh itu buat GLN dimana emang ada validasi check digit, sementara SIM dari apa yang gw cari referensinya gak ada validasi check digit
  3. Trus untuk fungsi search duplicatenya, menurut gw cukup pake SQL constraints

@andhit-r andhit-r mentioned this pull request Dec 21, 2016
Merged
@andhit-r
Copy link
Member

Superseded by #2 . Closing.

@andhit-r andhit-r closed this Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andhit-r andhit-r andhit-r requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikevhe18 @codecov-io @coveralls @andhit-r