8.0.5.1.2 l10n id taxform bukti potong common #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andhit-r
requested changes
Jun 26, 2019
l10n_id_taxform_bukti_potong_pph_common/models/account_move_line.py
Outdated
Show resolved
Hide resolved
|
|
||
| @api.multi | ||
| def _check_taxform(self, move_line): | ||
| self._cr.execute( |
There was a problem hiding this comment.
tambahkan lg self.ensure_one() jika menggunakan api.multi
| """SELECT 1 FROM rel_bukpot_line_2_income_move | ||
| WHERE account_move_id=%s | ||
| """, | ||
| (move_line.id,)) |
There was a problem hiding this comment.
self.id jika menggunakan api.multi
| @api.multi | ||
| def unlink(self): | ||
| for move_line in self: | ||
| taxform = self._check_taxform(move_line) |
There was a problem hiding this comment.
self._check_taxform() jika _check_taxform menggunakan api.multi
mikevhe18
force-pushed
the
8.0.5.1.2-l10n_id_taxform_bukti_potong_common
branch
from
8c654f1
to
d62773f
Compare
Codecov Report
@@ Coverage Diff @@
## 8.0 #138 +/- ##
==========================================
- Coverage 60.17% 60.05% -0.13%
==========================================
Files 115 116 +1
Lines 2968 2984 +16
==========================================
+ Hits 1786 1792 +6
- Misses 1182 1192 +10
Continue to review full report at Codecov.
|
andhit-r
requested changes
Jun 26, 2019
| @api.multi | ||
| def unlink(self): | ||
| for move_line in self: | ||
| taxform = self._check_taxform() |
There was a problem hiding this comment.
@mikevhe18 ini berarti move_line._check_taxform()
mikevhe18
force-pushed
the
8.0.5.1.2-l10n_id_taxform_bukti_potong_common
branch
from
d62773f
to
39b967f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.