Use UUID instead of ULID #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates OpAMP spec to 0.9.0 and implements spec change open-telemetry/opamp-spec#186 The example server still accepts old-style ULID agent instances to demonstrate how this change can be handled in a backward compatible way. Replace ULIDs by 16 byte ids and recommend UUID v7 (open-telemetry#186)
tigrannajaryan
force-pushed
the
feature/tigran/uuid
branch
from
5fc4f1c
to
d44e1d5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
+ Coverage 75.07% 75.18% +0.10%
==========================================
Files 25 25
Lines 1657 1656 -1
==========================================
+ Hits 1244 1245 +1
+ Misses 300 299 -1
+ Partials 113 112 -1 ☔ View full report in Codecov by Sentry. |
|
@open-telemetry/opamp-go-approvers please review. |
srikanthccv
approved these changes
May 27, 2024
|
@andykellr FYI, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates OpAMP spec to 0.9.0 and implements spec change open-telemetry/opamp-spec#186
The example server still accepts old-style ULID agent instances to
demonstrate how this change can be handled in a backward compatible way.
Replace ULIDs by 16 byte ids and recommend UUID v7 (#186)