[exporter/datasetexporter]: Allow specifying serverHost #24252
Labels
Comments
martin-majlis-s1
added
enhancement
martin-majlis-s1
changed the title
mx-psi
pushed a commit
that referenced
this issue
Aug 2, 2023
… retry_shutdown_timeout (#24415) **Description:** Introduce `server_host` configuration to allow specifying server host and `retry_shutdown_timeout` to specify time for the shutdown function There is new configuration option `server_host` that allows specifying how to fill the field `ServerHost` of the `Event` structure. New configuration for `server_host` looks like this: ``` server_host: # If these attributes are not specified or empty, # use the value from the env variable SERVER_HOST use_host: ${env:SERVER_HOST} # If it's not set, use the hostname value use_hostname: true ``` This configuration is applied for logs and traces. Since it's touching the same code, I have already merged changes from this PR - #23881 - into this branch, hoping that it will be merged soon. It's still not merged, so it's blocked by this. New configuration for `retry_shutdown_timeout` looks like this: ``` buffer: # Send buffer to the API at least every 5s max_lifetime: 5s # Group data based on these attributes group_by: - attributes.container_id - container_id # try to send data to the DataSet for at most 30s during shutdown retry_shutdown_timeout: 30s ``` This configuration specifies how much time the shutdown function has to send all the data that it has already accepted. **Link to tracking Issue:** #24252 **Testing:** I have added several unit tests to make sure that it works as expected. **Documentation:** There is new section in the README describing the newly added configuration options. --------- Co-authored-by: tomas.zdara <tomas.zdara@sentinelone.com> Co-authored-by: Tomaz Muraus <tomazm@sentinelone.com> Co-authored-by: Tomaz Muraus <126863902+tomaz-s1@users.noreply.github.com>
|
This was implemented in the PR #24415 |
|
/label exporter/datasetexporter |
|
/label exporter/dataset -needs-triage |
github-actions
bot
added
exporter/dataset
and removed
needs triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
exporter/dataset
Is your feature request related to a problem? Please describe.
To handle the data correctly by the DataSet servers it's good to specify serverHost attribute. Currently there is no easy way how to achieve that.
Describe the solution you'd like
Introduce some configuration option, that would allow specifying it.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: