Exporter/Datadog: improve trace exporter performance #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sublayer calculator is reset every time stats are computed so there is no need to use one per trace. We still use one per `push` call since it is not thread safe
Codecov Report
@@ Coverage Diff @@
## master #1706 +/- ##
==========================================
- Coverage 89.54% 89.53% -0.01%
==========================================
Files 373 373
Lines 18233 18229 -4
==========================================
- Hits 16326 16321 -5
- Misses 1417 1418 +1
Partials 490 490
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mx-psi
approved these changes
Nov 26, 2020
tigrannajaryan
approved these changes
Nov 26, 2020
mx-psi
added a commit
to mx-psi/aws-otel-collector
that referenced
this pull request
Nov 30, 2020
…tor-contrib@fabde15 This is to incorporate the changes in open-telemetry/opentelemetry-collector-contrib#1706 and open-telemetry/opentelemetry-collector-contrib#1707 All dependencies need to be updated because open-telemetry/opentelemetry-collector-contrib#1702 introduces breaking changes
mxiamxia
pushed a commit
to aws-observability/aws-otel-collector
that referenced
this pull request
Nov 30, 2020
…tor-contrib@fabde15 (#190) This is to incorporate the changes in open-telemetry/opentelemetry-collector-contrib#1706 and open-telemetry/opentelemetry-collector-contrib#1707 All dependencies need to be updated because open-telemetry/opentelemetry-collector-contrib#1702 introduces breaking changes
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
This is necessary to prevent circular package dependency that can arise when we need to hide certain pdata functions in the internal package in a commit that is coming soon in open-telemetry/opentelemetry-collector#1703 Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
The makeSamplingDecision function is a wrapper around the provider sampler calling ShouldSample with a duplicate configuration struct. That duplication and need for translation as well as the addition function call is unnecessary, this function is called in only one place. Resolves #1706
gotikkoxq
added a commit
to gotikkoxq/aws-otel-collector
that referenced
this pull request
Aug 26, 2024
…tor-contrib@fabde15 (#190) This is to incorporate the changes in open-telemetry/opentelemetry-collector-contrib#1706 and open-telemetry/opentelemetry-collector-contrib#1707 All dependencies need to be updated because open-telemetry/opentelemetry-collector-contrib#1702 introduces breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The cpu and memory usage of the tracer under heavy load is higher than where we'd like it to be, after investigating some profiles we found some areas where we could improve performance by re-using some components for generating statistics and improving trace translation logic
Testing:
Updated Unit tests