Upgrade otel collector core, fix changes for non-nullable InstrumentationLibrary #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
anuraaga,
dmitryax,
james-bebbington,
jmacd,
jpkrohling,
jrcamp,
kbrockhoff,
nilebox and
owais
as code owners
bogdandrutu
force-pushed
the
notnilil
branch
from
173d44a
to
943d73a
Compare
…tionLibrary Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
notnilil
branch
from
943d73a
to
5252b0b
Compare
jrcamp
approved these changes
Nov 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #1702 +/- ##
===========================================
+ Coverage 70.97% 89.53% +18.56%
===========================================
Files 33 373 +340
Lines 1509 18233 +16724
===========================================
+ Hits 1071 16325 +15254
- Misses 366 1419 +1053
- Partials 72 489 +417
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mx-psi
added a commit
to mx-psi/aws-otel-collector
that referenced
this pull request
Nov 30, 2020
…tor-contrib@fabde15 This is to incorporate the changes in open-telemetry/opentelemetry-collector-contrib#1706 and open-telemetry/opentelemetry-collector-contrib#1707 All dependencies need to be updated because open-telemetry/opentelemetry-collector-contrib#1702 introduces breaking changes
mxiamxia
pushed a commit
to aws-observability/aws-otel-collector
that referenced
this pull request
Nov 30, 2020
…tor-contrib@fabde15 (#190) This is to incorporate the changes in open-telemetry/opentelemetry-collector-contrib#1706 and open-telemetry/opentelemetry-collector-contrib#1707 All dependencies need to be updated because open-telemetry/opentelemetry-collector-contrib#1702 introduces breaking changes
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
update design link
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
…date docs (#1702) * Rename WithDefaultSampler TracerProvider option to WithSampler The term "DefaultSampler" comes from early ideas of this project where there would be overriding samplers lower in the trace SDK. This overriding does not exist and if it is going to be introduced in the future the sampler associated with the TracerProvider is already scoped based on that association (no need to scope with a name). This renames the TracerProvider option to not include this anachronism. * Update PR number in CHANGELOG * Propagate rename * Update defaults documentation for TracerProvider * Update sdk/trace/provider.go Co-authored-by: Steven E. Harris <seh@panix.com> * Update sdk/trace/provider.go Co-authored-by: Steven E. Harris <seh@panix.com>
gotikkoxq
added a commit
to gotikkoxq/aws-otel-collector
that referenced
this pull request
Aug 26, 2024
…tor-contrib@fabde15 (#190) This is to incorporate the changes in open-telemetry/opentelemetry-collector-contrib#1706 and open-telemetry/opentelemetry-collector-contrib#1707 All dependencies need to be updated because open-telemetry/opentelemetry-collector-contrib#1702 introduces breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com