-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] remove promtail receiver from components #18459
Merged
codeboten
merged 1 commit into
open-telemetry:main
from
mar4uk:revert-adding-promtail-receiver-to-components
Feb 8, 2023
Merged
[chore] remove promtail receiver from components #18459
codeboten
merged 1 commit into
open-telemetry:main
from
mar4uk:revert-adding-promtail-receiver-to-components
Feb 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foresight Summary
View More Details⭕ changelog workflow has finished in 3 seconds (2 minutes 3 seconds less than
|
Job | Failed Steps | Tests | |
---|---|---|---|
changelog | - 🔗 | N/A | See Details |
⭕ build-and-test-windows workflow has finished in 5 seconds (40 minutes 27 seconds less than main
branch avg.) and finished at 8th Feb, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
windows-unittest-matrix | - 🔗 | N/A | See Details |
windows-unittest | - 🔗 | N/A | See Details |
✅ check-links workflow has finished in 46 seconds (1 minute 47 seconds less than main
branch avg.) and finished at 8th Feb, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
changed files | - 🔗 | N/A | See Details |
check-links | - 🔗 | N/A | See Details |
✅ telemetrygen workflow has finished in 1 minute 6 seconds (1 minute 53 seconds less than main
branch avg.) and finished at 8th Feb, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
build-dev | - 🔗 | N/A | See Details |
publish-latest | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
✅ prometheus-compliance-tests workflow has finished in 12 minutes 35 seconds (⚠️ 4 minutes 1 second more than main
branch avg.) and finished at 8th Feb, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
prometheus-compliance-tests | - 🔗 | ✅ 21 ❌ 0 ⏭ 0 🔗 | See Details |
build-and-test workflow has finished in 26 minutes 2 seconds (31 minutes 49 seconds less than main
branch avg.) and finished at 8th Feb, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
correctness-traces | N/A | ✅ 17 ❌ 0 ⏭ 0 🔗 | See Details |
correctness-metrics | N/A | ✅ 2 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, internal) | N/A | ✅ 561 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, extension) | N/A | ✅ 546 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, processor) | N/A | ✅ 1472 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, extension) | N/A | ✅ 546 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, internal) | N/A | ✅ 561 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, processor) | N/A | ✅ 1472 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, receiver-0) | N/A | ✅ 2574 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-0) | N/A | ✅ 2574 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, exporter) | N/A | ✅ 2444 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, exporter) | N/A | ✅ 2444 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, receiver-1) | N/A | ✅ 1958 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, other) | N/A | ✅ 4672 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, other) | N/A | ✅ 4672 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-1) | N/A | ✅ 1958 ❌ 0 ⏭ 0 🔗 | See Details |
integration-tests | N/A | ✅ 55 ❌ 0 ⏭ 0 🔗 | See Details |
✅ e2e-tests workflow has finished in 14 minutes 7 seconds (8 minutes 3 seconds less than main
branch avg.) and finished at 8th Feb, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
kubernetes-test | - 🔗 | N/A | See Details |
✅ load-tests workflow has finished in 20 minutes 52 seconds (⚠️ 4 minutes 17 seconds more than main
branch avg.) and finished at 8th Feb, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
loadtest (TestTraceAttributesProcessor) | - 🔗 | ✅ 3 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestIdleMode) | - 🔗 | ✅ 1 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) | - 🔗 | ✅ 8 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetric10kDPS|TestMetricsFromFile) | - 🔗 | ✅ 6 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | - 🔗 | ✅ 12 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | - 🔗 | ✅ 10 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestBallastMemory|TestLog10kDPS) | - 🔗 | ✅ 19 ❌ 0 ⏭ 0 🔗 | See Details |
setup-environment | - 🔗 | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
mar4uk
changed the title
remove promtail receiver from components
[chore] remove promtail receiver from components
Feb 8, 2023
mar4uk
force-pushed
the
revert-adding-promtail-receiver-to-components
branch
2 times, most recently
from
February 8, 2023 16:33
c64b049
to
9f54410
Compare
codeboten
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mar4uk!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR reverts adding promtail receiver to components 7f2998d
Have decided to remove promtail receiver from components because loki dependencies cause vulnerabilities
Link to tracking Issue:
#18072