Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/prometheus/prometheus from 0.41.0 to 0.42.0 causes issues #18403

Closed
codeboten opened this issue Feb 7, 2023 · 6 comments
Closed
Assignees
Labels
dependencies Pull requests that update a dependency file receiver/promtail

Comments

@codeboten
Copy link
Contributor

Component(s)

receiver/promtail

Describe the issue you're reporting

The upgrade of the library from 0.41.0 to 0.42.0 causes the following test failures in the promtail receiver:

# github.com/grafana/loki/clients/pkg/promtail/targets/file
Error: /home/runner/go/pkg/mod/github.com/grafana/loki@v1.6.2-0.20230127130729-855d2b74bc07/clients/pkg/promtail/targets/file/filetargetmanager.go:303:23: assignment mismatch: 1 variable but relabel.Process returns 2 values
note: module requires Go 1.19
# github.com/grafana/loki/clients/pkg/promtail/targets/docker
Error: /home/runner/go/pkg/mod/github.com/grafana/loki@v1.6.2-0.20230127130729-855d2b74bc07/clients/pkg/promtail/targets/docker/target.go:206:16: assignment mismatch: 1 variable but relabel.Process returns 2 values
note: module requires Go 1.19
# github.com/grafana/loki/clients/pkg/promtail/targets/gelf
Error: /home/runner/go/pkg/mod/github.com/grafana/loki@v1.6.2-0.20230127130729-855d2b74bc07/clients/pkg/promtail/targets/gelf/gelftarget.go:125:15: assignment mismatch: 1 variable but relabel.Process returns 2 values
note: module requires Go 1.19
# github.com/grafana/loki/clients/pkg/promtail/targets/heroku
Error: /home/runner/go/pkg/mod/github.com/grafana/loki@v1.6.2-0.20230127130729-855d2b74bc07/clients/pkg/promtail/targets/heroku/target.go:132:16: assignment mismatch: 1 variable but relabel.Process returns 2 values
note: module requires Go 1.19
# github.com/grafana/loki/clients/pkg/promtail/targets/kafka
Error: /home/runner/go/pkg/mod/github.com/grafana/loki@v1.6.2-0.20230127130729-855d2b74bc07/clients/pkg/promtail/targets/kafka/formatter.go:17:15: assignment mismatch: 1 variable but relabel.Process returns 2 values
note: module requires Go 1.19
# github.com/grafana/loki/clients/pkg/promtail/targets/gcplog
Error: /home/runner/go/pkg/mod/github.com/grafana/loki@v1.6.2-0.20230127130729-855d2b74bc07/clients/pkg/promtail/targets/gcplog/formatter.go:63:15: assignment mismatch: 1 variable but relabel.Process returns 2 values
note: module requires Go 1.19
# github.com/grafana/loki/clients/pkg/promtail/targets/syslog
Error: /home/runner/go/pkg/mod/github.com/grafana/loki@v1.6.2-0.20230127130729-855d2b74bc07/clients/pkg/promtail/targets/syslog/syslogtarget.go:147:15: assignment mismatch: 1 variable but relabel.Process returns 2 values
note: module requires Go 1.19
# github.com/grafana/loki/clients/pkg/promtail/targets/lokipush
Error: /home/runner/go/pkg/mod/github.com/grafana/loki@v1.6.2-0.20230127130729-855d2b74bc07/clients/pkg/promtail/targets/lokipush/pushtarget.go:129:16: assignment mismatch: 1 variable but relabel.Process returns 2 values
note: module requires Go 1.19
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/promtailreceiver [build failed]

See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/4110972500/jobs/7094339944 for more details

@codeboten codeboten added the dependencies Pull requests that update a dependency file label Feb 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jpkrohling
Copy link
Member

@mar4uk, are you able to take a look at this one?

@mar4uk
Copy link
Contributor

mar4uk commented Feb 7, 2023

yes, I'm checking

@codeboten
Copy link
Contributor Author

Thanks @mar4uk @jpkrohling!

@mar4uk
Copy link
Contributor

mar4uk commented Feb 8, 2023

Here is a PR to revert adding promtail receiver to the components #18459
It will fix an issue with bumping prometheus version and dependabot vulnerabilities report

@codeboten
Copy link
Contributor Author

The prom dependency has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file receiver/promtail
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants