Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] lokireceiver. update to use generated header #21084

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

mar4uk
Copy link
Contributor

@mar4uk mar4uk commented Apr 20, 2023

Description:
Updates lokireceiver to use new generated status header. There are no warnings to list.
Updated README a little bit: ports for HTTP and gRPC were mixed up. Fixed

Link to tracking Issue: #19172

@mar4uk mar4uk requested a review from a team April 20, 2023 08:37
@mar4uk mar4uk changed the title Lokireceiver generated header [chore] Lokireceiver generated header Apr 20, 2023
@mar4uk mar4uk changed the title [chore] Lokireceiver generated header [chore] lokireceiver. update to use generated header Apr 20, 2023
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 20, 2023
@mar4uk mar4uk requested a review from codeboten April 20, 2023 09:54
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase to pick up the changes to skip a problematic unit test

@codeboten codeboten added the ready to merge Code review completed; ready to merge by maintainers label Apr 21, 2023
@mar4uk mar4uk force-pushed the lokireceiver-generated-header branch from f66318d to 2fcaa81 Compare April 21, 2023 09:09
@codeboten codeboten merged commit 8268905 into open-telemetry:main Apr 24, 2023
@github-actions github-actions bot added this to the next release milestone Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/loki Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants