Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl]: Add ParseXML converter #31487

Merged

Conversation

BinaryFissionGames
Copy link
Contributor

Description:

  • Adds a ParseXML converter function that can be used to parse an XML document to a pcommon.Map value

Link to tracking Issue: Closes #31133

Testing:
Unit tests
Manually tested parsing XML logs

Documentation:
Added documentation for the ParseXML function to the ottl_funcs README.

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from an xml parsing perspective

@BinaryFissionGames
Copy link
Contributor Author

@TylerHelmuth @evan-bradley Any thoughts on this one?

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evan-bradley please take a look

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

pkg/ottl/ottlfuncs/func_parse_xml_test.go Outdated Show resolved Hide resolved
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
@TylerHelmuth TylerHelmuth merged commit 0d9b1b0 into open-telemetry:main Mar 15, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pkg/ottl]: Add a ParseXML converter to parse XML strings
4 participants