Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/stanza] Fix tests on Windows #32305

Merged
merged 1 commit into from
Apr 10, 2024
Merged

[pkg/stanza] Fix tests on Windows #32305

merged 1 commit into from
Apr 10, 2024

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Apr 10, 2024 •
edited
Loading

@dmitryax dmitryax requested review from djaglowski and a team as code owners April 10, 2024 20:43
@dmitryax dmitryax added the Run Windows Enable running windows test on a PR label Apr 10, 2024
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 10, 2024
crobert-1
crobert-1 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should resolve #32299

@dmitryax dmitryax merged commit a86e505 into open-telemetry:main Apr 10, 2024
178 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 10, 2024
@dmitryax dmitryax deleted the fix-windows-tests branch April 10, 2024 22:56
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this pull request May 8, 2024
@dmitryax @rimitchell
[pkg/stanza] Fix tests on Windows (open-telemetry#32305)
b3a6257 
Fix tests failing in
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8637187949/job/23678820573

Resolves
open-telemetry#32299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@bryan-aguilar bryan-aguilar bryan-aguilar approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

Assignees

@Aneurysm9 Aneurysm9

Labels
pkg/stanza Run Windows Enable running windows test on a PR Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.98.0
Development

Successfully merging this pull request may close these issues.

[pkg/stanza/fileconsumer] More tests failing intermittently on Windows
5 participants
@dmitryax @codeboten @bryan-aguilar @crobert-1 @Aneurysm9