Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove duplicate code from the connector #10082

Merged
merged 4 commits into from
May 6, 2024

Conversation

bogdandrutu
Copy link
Member

No description provided.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested review from a team and mx-psi May 4, 2024 01:16
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (8aaec09) to head (4c3a53f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10082      +/-   ##
==========================================
- Coverage   91.86%   91.84%   -0.02%     
==========================================
  Files         361      362       +1     
  Lines       16722    16709      -13     
==========================================
- Hits        15361    15346      -15     
- Misses       1024     1025       +1     
- Partials      337      338       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

connector/router.go Outdated Show resolved Hide resolved
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing Dmitrii's comment

connector/router.go Outdated Show resolved Hide resolved
connector/router.go Outdated Show resolved Hide resolved
@codeboten codeboten merged commit 8efff48 into open-telemetry:main May 6, 2024
47 checks passed
@github-actions github-actions bot added this to the next release milestone May 6, 2024
andrzej-stencel pushed a commit to andrzej-stencel/opentelemetry-collector that referenced this pull request May 27, 2024
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@bogdandrutu bogdandrutu deleted the rmduplicatecode branch October 14, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants