[otelcoltest] Move otelcoltest to its own module

[TylerHelmuth]

Description

As part of #10290, move otelcoltest to its own module.

Link to tracking issue

Related to #10290

[codecov]

Codecov Report

Attention: Patch coverage is 18.86792% with 43 lines in your changes missing coverage. Please review.

Project coverage is 92.27%. Comparing base (b3c781b) to head (79865d7).

❗ Current head 79865d7 differs from pull request most recent head 950bcd5

Please upload reports for the commit 950bcd5 to get more accurate results.

Files	Patch %	Lines
otelcoltest/config.go	15.38%	31 Missing and 2 partials ⚠️
otelcoltest/nop_factories.go	28.57%	5 Missing and 5 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10417      +/-   ##
==========================================
- Coverage   92.35%   92.27%   -0.09%     
==========================================
  Files         388      388              
  Lines       18445    18461      +16     
==========================================
  Hits        17035    17035              
- Misses       1055     1065      +10     
- Partials      355      361       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mx-psi]

I think there was a reason for this, but I don't remember why we need to change the path and we can't just leave it in its current folder. Could you explain the motivation for that?

[TylerHelmuth]

@mx-psi Turns out that LoadConfig was used a lot in Contrib and it would be nice to keep using the version that depends on the providers/converters. We are trying to remove them from otelcol dependencies, but in this case the function is useful for our Contrib tests.

We could create an internal package in Contrib and duplicate this logic, but this way felt better.

If we want to do the Contrib solution, I think we should remove LoadConfig and LoadConfigAndValidate entirely.

[mx-psi]

@mx-psi Turns out that LoadConfig was used a lot in Contrib and it would be nice to keep using the version that depends on the providers/converters. We are trying to remove them from otelcol dependencies, but in this case the function is useful for our Contrib tests.

We could create an internal package in Contrib and duplicate this logic, but this way felt better.

If we want to do the Contrib solution, I think we should remove LoadConfig and LoadConfigAndValidate entirely.

@TylerHelmuth What I was asking is: why don't we add a go.mod and go.sum files to the current otelcol/otelcoltest folder instead of moving things to a top-level otelcoltest? Is there anything that prevents that?

[TylerHelmuth]

@mx-psi oh I see what you mean. I dont see an issue with doing it that way, I'll update the PR

[TylerHelmuth]

@mx-psi crosslink doesn't like having the nested structure. The replace statements need to use ../../ but it generates ../

[mx-psi]

@TylerHelmuth We do have that structure on pdata and pdata/pprofile/pdata/testdata though 🤔

[TylerHelmuth]

@mx-psi you're right, I needed to get the module name nested correctly.

[mx-psi]

Almost there!