Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing policy names in README example #385

Closed

Conversation

pedro-ribeiro
Copy link
Contributor

This relates to issue open-telemetry/opentelemetry-collector-contrib#30155 since I couldn't find the mentioned policy.

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@01d8d94). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     open-telemetry/opentelemetry-collector#385   +/-   ##
=========================================
  Coverage          ?   74.45%           
=========================================
  Files             ?      116           
  Lines             ?     6988           
  Branches          ?        0           
=========================================
  Hits              ?     5203           
  Misses            ?     1525           
  Partials          ?      260

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01d8d94...105e113. Read the comment docs.

@pedro-ribeiro
Copy link
Contributor Author

I signed it

@pedro-ribeiro pedro-ribeiro deleted the fixing_examples branch October 9, 2019 14:56
@pedro-ribeiro pedro-ribeiro restored the fixing_examples branch October 9, 2019 14:56
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…n-telemetry#385)

* draft using stop aggregating on prometheus client (counters)

* remove prometheus client aggregations

Measures are being exported as summaries since histograms doesn't
exist on OpenTelemetry yet.

Better error handling must be done.

* make pre commit

* add simple error callback

* remove options from collector

* refactor exporter to smaller methods

* wording

* change to snapshot

* lock collection and checkpointset read

* remove histogram options and unexported fields from the Exporter

* documenting why prometheus uses a stateful batcher

* add todo for histograms

* change summaries objects to summary quantiles

* remove histogram buckets from tests

* wording

* rename 'lockedCheckpoint' to 'syncCheckpointSet'

* default summary quantiles should be defaulted to no buckets.

* add quantiles options

* refactor test.CheckpointSet and add docs

* flip aggregators merge

Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants