Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/logging] Deprecate 'loglevel' in favor of 'verbosity' #6334

Merged
merged 7 commits into from
Oct 24, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 17, 2022

Description:

  • Add verbosity option
  • Deprecate loglevel in favor of verbosity option
  • Add warning log if loglevel option is used

Link to tracking Issue: Updates #5878

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 92.06% // Head: 91.81% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (7174071) compared to base (ee02bc7).
Patch coverage: 64.81% of modified lines in pull request are covered.

❗ Current head 7174071 differs from pull request most recent head 3ef6fc7. Consider uploading reports for the commit 3ef6fc7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6334      +/-   ##
==========================================
- Coverage   92.06%   91.81%   -0.25%     
==========================================
  Files         219      231      +12     
  Lines       13242    13455     +213     
==========================================
+ Hits        12191    12354     +163     
- Misses        828      874      +46     
- Partials      223      227       +4     
Impacted Files Coverage Δ
exporter/loggingexporter/factory.go 88.88% <33.33%> (-11.12%) ⬇️
exporter/loggingexporter/config.go 71.79% <70.27%> (+71.79%) ⬆️
exporter/loggingexporter/logging_exporter.go 79.24% <100.00%> (-0.76%) ⬇️
pdata/plog/pb.go 71.42% <0.00%> (-28.58%) ⬇️
pdata/ptrace/pb.go 71.42% <0.00%> (-28.58%) ⬇️
pdata/pmetric/pb.go 71.42% <0.00%> (-28.58%) ⬇️
pdata/ptrace/json.go 53.33% <0.00%> (-26.67%) ⬇️
pdata/pmetric/json.go 53.33% <0.00%> (-26.67%) ⬇️
pdata/plog/json.go 73.33% <0.00%> (-26.67%) ⬇️
confmap/confmap.go 91.61% <0.00%> (-1.94%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

exporter/loggingexporter/testdata/config_verbosity.yaml Outdated Show resolved Hide resolved
exporter/loggingexporter/config.go Outdated Show resolved Hide resolved
exporter/loggingexporter/config.go Show resolved Hide resolved
exporter/loggingexporter/config.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants