Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shippingservice] add grpc conventions #597

Merged
merged 2 commits into from
Nov 21, 2022
Merged

[shippingservice] add grpc conventions #597

merged 2 commits into from
Nov 21, 2022

Conversation

ty-elastic
Copy link
Contributor

Fixes #596

Changes

  • use OTEL semantic conventions where defined
  • name tracer in accordance with other services which sink grpc transactions
  • name span in accordance with OTEL grpc conventions
  • set SpanKind to SERVER for functions sinking grpc transactions
  • set RpcSystem to grpc
  • Set RpcGrpcStatusCode appropriately

@ty-elastic ty-elastic requested a review from a team November 19, 2022 02:23
julianocosta89
julianocosta89 reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ty-elastic could you also update the docs?
https://github.com/open-telemetry/opentelemetry-demo/blob/main/docs/services/shippingservice.md

julianocosta89
julianocosta89 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ty-elastic ty-elastic force-pushed the ty-elastic/shippingservice-grpc branch from f14d414 to baaf074 Compare November 21, 2022 14:17
@ty-elastic
Copy link
Contributor Author

@julianocosta89, docs updated as appropriate! thanks!

julianocosta89
julianocosta89 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ty-elastic !
LGTM

@austinlparker austinlparker merged commit 7d4b9d9 into open-telemetry:main Nov 21, 2022
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@ty-elastic @austinlparker
[shippingservice] add grpc conventions (open-telemetry#597)
53452c5 
Co-authored-by: Austin Parker <austin@ap2.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianocosta89 julianocosta89 julianocosta89 approved these changes

@austinlparker austinlparker austinlparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[shippingservice] improve support for grpc
3 participants
@ty-elastic @austinlparker @julianocosta89