Remove dd_agent from Azure Pipelines #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
reviewed
Feb 12, 2021
| @@ -87,6 +70,7 @@ jobs: | |||
| test/**/*.Tests.csproj | |||
| test/benchmarks/**/*.csproj | |||
| !src/Datadog.Trace.Tools.Runner/*.csproj | |||
| !test/Vendored.System.Diagnostics.DiagnosticSource.Tests/Vendored.System.Diagnostics.DiagnosticSource.Tests.csproj | |||
There was a problem hiding this comment.
This is a left-over from when I was pushing this stuff to the main branch. Now I changed my mind and think that it will be better to remove this project from main and continue the work related to it on the branch that @macrogreg worked on at the end of last year.
@macrogreg If you agree let's remove the vendored S.D.DS from main.
@pellared please keep this as it is on this PR and wait on an agreement if we are removing this from main.
There was a problem hiding this comment.
@pjanotti @macrogreg
PR which removes the vedored stuff: #52
|
I have created 2 additional PRs
|
pjanotti
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #44
What
unit-tests.yml. Created CI is unable to build Vendored.System.Diagnostics.DiagnosticSource.Tests.csproj #49 and Remove Vendored.System.Diagnostics.DiagnosticSource.Tests #52 to fix it.Other Findings
I believe only changes in
unit-test.ymldo something at the moment. Thebenchmark.ymlandrunner.ymlare most probably not configured at all. Not sure if we should enable these pipelines as well.Notes for Reviewers
As I am a newcomer, please assume I know nothing.
Is there something more that should be removed?
Is there something similar to Datadog Agent in OpenTelemetry that we could use in the CI pipeline to have some kind of monitoring if everything is stable?
I have not maintained the branch in the way described under https://github.com/kubernetes/community/blob/master/contributors/guide/github-workflow.md . I intend to "Squash merge" this PR. If you see a problem with it I can always create a new PR with a cleaner history/commits.