Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PrometheusTagTransformer #3312

Closed
wants to merge 12 commits into from
Closed

Add PrometheusTagTransformer #3312

wants to merge 12 commits into from

Conversation

alanwest
Copy link
Member

@alanwest alanwest commented May 28, 2022 •
edited
Loading

Final PR addressing both #2010 and #3229.

Put some questions in the PR. If folks know any of the answers let me know. Otherwise I'll pursue the answers next week.

@codecov
Copy link

codecov bot commented May 28, 2022 •
edited
Loading

Codecov Report

Merging #3312 (706798f) into main (fd24811) will increase coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3312      +/-   ##
==========================================
+ Coverage   86.08%   86.43%   +0.34%     
==========================================
  Files         270      275       +5     
  Lines        9482    10083     +601     
==========================================
+ Hits         8163     8715     +552     
- Misses       1319     1368      +49
Impacted Files Coverage Δ
...rter.Jaeger/Implementation/JaegerTagTransformer.cs 100.00% <100.00%> (ø)
....Prometheus/Implementation/PrometheusSerializer.cs 85.85% <100.00%> (+8.08%) ⬆️
...ometheus/Implementation/PrometheusSerializerExt.cs 100.00% <100.00%> (ø)
...metheus/Implementation/PrometheusTagTransformer.cs 100.00% <100.00%> (ø)
...rter.Zipkin/Implementation/ZipkinTagTransformer.cs 100.00% <100.00%> (ø)
...c/OpenTelemetry/Logs/OpenTelemetryLoggerOptions.cs 86.95% <0.00%> (-13.05%) ⬇️
src/OpenTelemetry/Logs/LogRecord.cs 85.40% <0.00%> (-11.57%) ⬇️
...penTelemetry/Logs/BatchLogRecordExportProcessor.cs 92.30% <0.00%> (-7.70%) ⬇️
...elemetry/Metrics/MeterProviderBuilderExtensions.cs 67.30% <0.00%> (-4.13%) ⬇️
src/OpenTelemetry/Resources/ResourceBuilder.cs 96.07% <0.00%> (-3.93%) ⬇️
... and 22 more

@alanwest alanwest mentioned this pull request Jun 2, 2022
Merged
alanwest
alanwest commented Jun 4, 2022
View reviewed changes
test/OpenTelemetry.Exporter.Prometheus.Tests/PrometheusSerializerTests.cs
Assert.Matches(
("^"
+ "# TYPE test_counter counter\n"
+ "test_counter 10 \\d+\n"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attribute is dropped. Is that what we want?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel either empty string or dropped would be fine.
Anyways we'll have to stick with the spec once it becomes Stable (currently the Prometheus workgroup is still hammering out the rules).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stuck with dropping it for now. Though I also changed it to drop empty string valued attributes as well since I suspect it makes sense to handle both of these scenarios the same.

@alanwest alanwest marked this pull request as ready for review June 4, 2022 00:21
@alanwest alanwest requested a review from a team June 4, 2022 00:21
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jun 17, 2022
@alanwest alanwest removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jun 17, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jun 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2022

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jul 2, 2022
@alanwest
Copy link
Member Author

alanwest commented Jul 6, 2022

Went stale reopening for review.

@alanwest alanwest reopened this Jul 6, 2022
@alanwest alanwest removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jul 6, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jul 14, 2022
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch left review comments

@reyang reyang reyang approved these changes

Assignees
No one assigned
Labels
Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alanwest @reyang @CodeBlanch @cijothomas