GrpcNetClient Instrumentation to leverage native Activity Status. #3569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3569 +/- ##
=======================================
Coverage ? 87.24%
=======================================
Files ? 278
Lines ? 10087
Branches ? 0
=======================================
Hits ? 8800
Misses ? 1287
Partials ? 0
|
cijothomas
reviewed
Aug 11, 2022
| @@ -61,7 +61,7 @@ public void GrpcTagHelper_GetGrpcStatusCodeFromActivity() | |||
| var statusCode = GrpcTagHelper.ResolveSpanStatusForGrpcStatusCode(status); | |||
| activity.SetTag(SemanticConventions.AttributeRpcGrpcStatusCode, status); | |||
|
|
|||
| Assert.Equal(StatusCode.Unset, statusCode.StatusCode); | |||
| Assert.Equal(ActivityStatusCode.Unset, statusCode); | |||
There was a problem hiding this comment.
surprised that we had no tests with status being Error?
cijothomas
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards #3118.