Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InMemoryExporter] Include original stack trace in ObjectDisposedException #3609

Merged
merged 5 commits into from
Aug 26, 2022

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Aug 26, 2022

Relates to #3607

Added the stack trace for the original Dispose call to the message when we throw ObjectDisposedException inside the In-memory Exporter (to help track down issues). Fixed a couple flaky tests that helped me track down 😄

/cc @reyang

@CodeBlanch CodeBlanch requested a review from a team August 26, 2022 20:04
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #3609 (12ed5a6) into main (372767a) will increase coverage by 0.10%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3609      +/-   ##
==========================================
+ Coverage   87.15%   87.26%   +0.10%     
==========================================
  Files         277      277              
  Lines        9950     9953       +3     
==========================================
+ Hits         8672     8685      +13     
+ Misses       1278     1268      -10     
Impacted Files Coverage Δ
...penTelemetry.Exporter.InMemory/InMemoryExporter.cs 81.81% <25.00%> (-12.92%) ⬇️
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...OpenTelemetry/Metrics/BaseExportingMetricReader.cs 86.15% <0.00%> (-4.62%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 77.50% <0.00%> (-2.50%) ⬇️
...tpListener/Internal/PrometheusCollectionManager.cs 78.04% <0.00%> (-2.44%) ⬇️
src/OpenTelemetry/Metrics/MetricReader.cs 88.13% <0.00%> (-1.70%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 96.15% <0.00%> (+4.39%) ⬆️
...tation/OpenTelemetryProtocolExporterEventSource.cs 85.00% <0.00%> (+10.00%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 77.27% <0.00%> (+40.90%) ⬆️
... and 1 more

@CodeBlanch CodeBlanch merged commit 28c0bcc into open-telemetry:main Aug 26, 2022
@CodeBlanch CodeBlanch deleted the inmem-2 branch August 26, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants