Add back Guard.ThrowIfNull batch options #4608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4608 +/- ##
==========================================
- Coverage 84.92% 84.90% -0.03%
==========================================
Files 313 313
Lines 12601 12604 +3
==========================================
Hits 10701 10701
- Misses 1900 1903 +3
|
utpilla
approved these changes
Jun 21, 2023
vishweshbankwar
approved these changes
Jun 21, 2023
CodeBlanch
reviewed
Jun 22, 2023
| @@ -38,7 +41,7 @@ public LogRecordExportProcessorOptions() | |||
| { | |||
| Debug.Assert(defaultBatchExportLogRecordProcessorOptions != null, "defaultBatchExportLogRecordProcessorOptions was null"); | |||
|
|
|||
| this.BatchExportProcessorOptions = defaultBatchExportLogRecordProcessorOptions ?? new(); | |||
| this.batchExportProcessorOptions = defaultBatchExportLogRecordProcessorOptions ?? new(); | |||
There was a problem hiding this comment.
Why is the ?? new() here? My guess would be to suppress a warning for old targets. Just FYI the ! operatior is fine for that: this.batchExportProcessorOptions = defaultBatchExportLogRecordProcessorOption!
On newer targets Debug.Assert is smarter (decorated) to make the analysis happy.
New targets:
public static void Assert([DoesNotReturnIf(false)] bool condition, string? message);
Old targets:
public static void Assert(bool condition, string message);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vishweshbankwar oops, sorry, I glossed over this reviewing your update regarding #4575 (comment)
Since you made the property not nullable, I think we want to keep the Guard.ThrowIfNull so that it's certain not to be null.