-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for migration to new runtime metrics #5747
Prepare for migration to new runtime metrics #5747
Conversation
49c8ae0
to
fa050bc
Compare
|
||
// BoolFeature is an experimental feature control flag. It provides a uniform way | ||
// to interact with these feature flags and parse their values. | ||
type BoolFeature struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This differs from the "Feature" pattern used elsewhere because I wanted to be able to have a default value of "true". Rather than make the existing pattern more complex to support this, I simplified it to fit this packages' needs.
The value set must be the case-insensitive string of `"true"` to enable the | ||
feature, and `"false"` to disable the feature. All other values are ignored. | ||
|
||
[previous runtime metrics conventions]: go.opentelemetry.io/contrib/instrumentation/runtime/internal/deprecatedruntime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link will not work until after the next release.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5747 +/- ##
=====================================
Coverage 63.9% 63.9%
=====================================
Files 195 197 +2
Lines 12267 12285 +18
=====================================
+ Hits 7849 7862 +13
- Misses 4196 4201 +5
Partials 222 222
|
fa050bc
to
666c2e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Are we going to keep the same scope for the deprecated metrics, and will it be the same as the scope of the new metrics?
I was going to keep the same scope for the deprecated metrics. It doesn't make sense to me to modify the scope if they are going away anyways. |
Looks like this introduced a broken link. I'll look into submitting a fix. |
Part of #5655
This is a refactoring to prepare for the implementation of the new runtime metrics. It:
OTEL_GO_X_DEPRECATED_RUNTIME_METRICS
, which can be set totrue
orfalse
to enable/disable the existing runtime metrics. It initially defaults totrue
while the new metrics are under development.This does not change any of the metrics generated, or the public API surface of the runtime metrics package.