Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace offsets-tracker with a copy in internal/tools #281

Merged
merged 15 commits into from
Sep 12, 2023
Merged

Replace offsets-tracker with a copy in internal/tools #281

merged 15 commits into from
Sep 12, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 6, 2023 •
edited
Loading

Part of #270; this moves code that does not need to be exported into the internal package.

  • Deprecate offsets-tracker
  • Copy existing offsets-tracker into a new internal/tools/offsets package
  • Update tooling to use new package

@MrAlias MrAlias marked this pull request as ready for review September 6, 2023 15:07
@MrAlias MrAlias requested a review from a team September 6, 2023 15:07
@MrAlias MrAlias mentioned this pull request Sep 5, 2023
Closed
5 tasks
pellared
pellared approved these changes Sep 7, 2023
View reviewed changes
.github/workflows/build.yaml Show resolved Hide resolved
@MrAlias MrAlias mentioned this pull request Sep 11, 2023
Closed
@MrAlias MrAlias merged commit 08e8292 into open-telemetry:main Sep 12, 2023
13 checks passed
@MrAlias MrAlias deleted the mv-offsets-tracker-internal branch September 12, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrAlias @MikeGoldsmith @pellared