Ensure net http client code also works with the RoundTripper interface #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonFed
reviewed
Dec 2, 2023
|
Thanks @RonFed, I made the requested changes and fixed up the lint issues. |
RonFed
approved these changes
Dec 3, 2023
MrAlias
approved these changes
Dec 3, 2023
pellared
approved these changes
Dec 4, 2023
MikeGoldsmith
approved these changes
Dec 4, 2023
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I'm adding support for tracking HTTP client requests which use the RoundTripper interface. The client.Do probe will not catch these events, but there's a lower level rountrip method on Transport, which handles all HTTP client calls.
I'm also adding a new integration test which covers the now fixed issue for duplicate server requests and missing response codes (for #472), as well as this RoundTripper client call.