Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving github.com/DataDog/sketches-go to 1.0.0 #1417

Closed
eclipseo opened this issue Dec 21, 2020 · 2 comments · Fixed by #1412
Closed

Consider moving github.com/DataDog/sketches-go to 1.0.0 #1417

eclipseo opened this issue Dec 21, 2020 · 2 comments · Fixed by #1412
Labels
area:metrics Part of OpenTelemetry Metrics question Further information is requested

Comments

@eclipseo
Copy link

Hi,

I'd like to package open-telemetry for my distro, but we have system-wide github.com/DataDog/sketches-go at version 1.0.0. It has API breaking changes from 0.0.1. Could you consider updating the code to work with 1.0.0?

Thanks.

@krnowak
Copy link
Member

krnowak commented Dec 21, 2020

There is a PR that drops the dependency on DDSketch: #1412

@jmacd
Copy link
Contributor

jmacd commented Dec 21, 2020

FYI we plan on re-introducing this dependency. Some restructuring is needed in the OTel-Go SDK before we can get there, and we won't really be ready to use DDSketches in OTel-Go until open-telemetry/opentelemetry-proto#226 merges. Thanks.

@MrAlias MrAlias added area:metrics Part of OpenTelemetry Metrics question Further information is requested labels Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants