Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTLP gRPC example sets unreasonably low batch interval #1564

Closed
Aneurysm9 opened this issue Feb 20, 2021 · 0 comments · Fixed by #1621
Closed

OTLP gRPC example sets unreasonably low batch interval #1564

Aneurysm9 opened this issue Feb 20, 2021 · 0 comments · Fixed by #1621
Labels
documentation Provides helpful information good first issue Good for newcomers

Comments

@Aneurysm9
Copy link
Member

The OTLP gRPC examples set a batch timeout of 5ns. This should probably be 5s.

	tp := sdktrace.NewTracerProvider(
		sdktrace.WithConfig(sdktrace.Config{DefaultSampler: sdktrace.AlwaysSample()}),
		sdktrace.WithBatcher(
			exp,
			// add following two options to ensure flush
			sdktrace.WithBatchTimeout(5),
			sdktrace.WithMaxExportBatchSize(10),
		),
	)

Please update all examples to use sdktrace.WithBatchTimeout(5 * time.Second).
@Aneurysm9 Aneurysm9 added good first issue Good for newcomers documentation Provides helpful information pkg:exporter labels Feb 20, 2021
ijsong added a commit to ijsong/opentelemetry-go that referenced this issue Feb 28, 2021
@ijsong
Use reasonable interval in sdktrace.WithBatchTimeout
0af882d 
This patch resolves open-telemetry#1564.
@ijsong ijsong mentioned this issue Feb 28, 2021
Merged
MrAlias pushed a commit that referenced this issue Mar 1, 2021
@ijsong
Use reasonable interval in sdktrace.WithBatchTimeout (#1621)
1519d95 
* Use reasonable interval in sdktrace.WithBatchTimeout

This patch resolves #1564.

* Add pull request ID to CHANGELOG.md
ldelossa pushed a commit to ldelossa/opentelemetry-go that referenced this issue Mar 5, 2021
@ijsong @ldelossa
Use reasonable interval in sdktrace.WithBatchTimeout (open-telemetry#…
ed3afc7 
…1621)

* Use reasonable interval in sdktrace.WithBatchTimeout

This patch resolves open-telemetry#1564.

* Add pull request ID to CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Provides helpful information good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use reasonable interval in sdktrace.WithBatchTimeout ijsong/opentelemetry-go
1 participant
@Aneurysm9