Use reasonable interval in sdktrace.WithBatchTimeout #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch resolves open-telemetry#1564.
ijsong
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1621 +/- ##
=====================================
Coverage 77.7% 77.7%
=====================================
Files 128 128
Lines 6637 6637
=====================================
Hits 5157 5157
Misses 1233 1233
Partials 247 247
|
XSAM
approved these changes
Mar 1, 2021
MrAlias
approved these changes
Mar 1, 2021
Merged
ldelossa
pushed a commit
to ldelossa/opentelemetry-go
that referenced
this pull request
Mar 5, 2021
…1621) * Use reasonable interval in sdktrace.WithBatchTimeout This patch resolves open-telemetry#1564. * Add pull request ID to CHANGELOG.md
This was referenced Mar 7, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resolves #1564.