Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use capitalizations-path flag in semconvgen to properly capitalize semantic conventions #5475

Closed
carrbs opened this issue Jun 3, 2024 · 0 comments · Fixed by #5894
Closed
Assignees
Labels
enhancement New feature or request pkg:semconv Related to a semconv package
Milestone

Comments

@carrbs
Copy link
Contributor

carrbs commented Jun 3, 2024

Semantic conventions for metrics were introduced in v1.24.0. Additionally, a flag was added to the semconvgenbuild tool providing a way to customize the capitalization of a specific string.

Update the Makefile to utilize the new flag in semconvgen to properly capitalize ASPNETCore and JVM:

$(SEMCONVGEN) -i "$(OTEL_SEMCONV_REPO)/model/." --only=metric -f metric.go -t "$(SEMCONVPKG)/metric_template.j2" -s "$(TAG)"

The issue in the build tools repository has a detailed example.

@carrbs carrbs added the enhancement New feature or request label Jun 3, 2024
@MrAlias MrAlias added the pkg:semconv Related to a semconv package label Jun 11, 2024
@MrAlias MrAlias self-assigned this Oct 18, 2024
@MrAlias MrAlias added this to the v1.32.0 milestone Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg:semconv Related to a semconv package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants