charts/opentelemetry-collector: recommended CPU limit pushes just over threshold #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinburkesegment
requested review from
dmitryax,
TylerHelmuth and
povilasv
as code owners
kevinburkesegment
changed the title
TylerHelmuth
reviewed
Aug 8, 2023
There was a problem hiding this comment.
@kevinburkesegment please bump the patch version of the chart and then run make generate-examples CHARTS=opentelemetry-collector.
While "256m" is a valid setting, the intention was likely to allow 4 pods to be scheduled on a single CPU, which we will currently overshoot by 24/1000, since there are only 1000 units in a CPU fraction. Adjust to "250m", which would allow exactly 4 pods to share a CPU. See e.g. https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-cpu
kevinburkesegment
force-pushed
the
limits
branch
from
1a5e3fb
to
7e3f892
Compare
|
Done |
TylerHelmuth
approved these changes
Aug 8, 2023
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
povilasv
added a commit
to coralogix/opentelemetry-helm-charts
that referenced
this pull request
Aug 18, 2023
* Bump collector version to 0.80.0 (open-telemetry#815) * [opentelemetry-collector] recombine cri multi-line logs (open-telemetry#818) * [demo] Bump OTel Collector chart version (open-telemetry#821) See: open-telemetry#817 (comment) Signed-off-by: Goutham <gouthamve@gmail.com> * Feat/extra env from (open-telemetry#820) * feat(collector-chart): add extraEnvFrom support * chore(examples): adding examples * bump operator (open-telemetry#823) * bump collector (open-telemetry#830) * JAC: fix checksum config in statefulset template (open-telemetry#827) * Adds short usage instructions to UPGRADING.md (open-telemetry#826) * Adds short usage instructions to UPGRADING.md * Updated chart version and regenerated examples * Bump operator (open-telemetry#832) * Fix typo in README.md (open-telemetry#831) * Add new helm command to README.md, fix typos (open-telemetry#836) * Add new helm command to README.md, fix typos + Add link to logging exporter * bump operator chart version * Revert "bump operator chart version" This reverts commit 91430ff. * bump operator patch version * Add externalTrafficPolicy value for service type LoadBalancer (open-telemetry#838) Signed-off-by: Alban HURTAUD <alban.hurtaud@amadeus.com> * [collector] Respect pipeline order when enabling kubernetesAttributes (open-telemetry#844) * fix pipeline order when enabling k8sattributes * bump collector and document breakage * kubernetesAttributes example * regenerate examples * Update charts/opentelemetry-collector/UPGRADING.md Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * [collector] Allow disabling service even for deployment and statefulset (open-telemetry#843) * Allow disabling all ports * temp * generate examples * Bump version * bump collector to 0.82.0 (open-telemetry#847) * charts/opentelemetry-collector: recommended CPU limit pushes just over threshold (open-telemetry#851) * charts/opentelemetry-collector: fix CPU limit While "256m" is a valid setting, the intention was likely to allow 4 pods to be scheduled on a single CPU, which we will currently overshoot by 24/1000, since there are only 1000 units in a CPU fraction. Adjust to "250m", which would allow exactly 4 pods to share a CPU. See e.g. https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-cpu * Update charts/opentelemetry-collector/values.yaml Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * Upgrade operator to v0.82.0 (open-telemetry#854) * Upgrade operator to v0.82.0 * ci: fix operator E2E tests * [collector] Allow disabling all ports (open-telemetry#842) * Allow disabling all ports * bump patch version instead * chore(demo): update chart dependencies (open-telemetry#856) * update chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * Bump collector version (open-telemetry#861) * Update clusterrole (open-telemetry#860) --------- Signed-off-by: Goutham <gouthamve@gmail.com> Signed-off-by: Alban HURTAUD <alban.hurtaud@amadeus.com> Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> Co-authored-by: Goutham Veeramachaneni <gouthamve+github@gmail.com> Co-authored-by: PaoloGallina <paologallina1992@gmail.com> Co-authored-by: Jorge Andreu Calatayud <11544239+jorgeancal@users.noreply.github.com> Co-authored-by: Peter Kern <peter@nomagic.net> Co-authored-by: Jan Katins <jasc@gmx.net> Co-authored-by: Marcin Ziółkowski <62351083+MA3CIN@users.noreply.github.com> Co-authored-by: Alban Hurtaud <alban.hurtaud@amadeus.com> Co-authored-by: Jakob Demler <jakob.demler@jedox.com> Co-authored-by: Kevin Burke <kevin.burke@segment.com> Co-authored-by: Mikołaj Świątek <mail+sumo@mikolajswiatek.com> Co-authored-by: Pierre Tessier <pierre@pierretessier.com>
povilasv
added a commit
to coralogix/opentelemetry-helm-charts
that referenced
this pull request
Dec 13, 2023
* Bump collector version to 0.80.0 (open-telemetry#815) * [opentelemetry-collector] recombine cri multi-line logs (open-telemetry#818) * [demo] Bump OTel Collector chart version (open-telemetry#821) See: open-telemetry#817 (comment) Signed-off-by: Goutham <gouthamve@gmail.com> * Feat/extra env from (open-telemetry#820) * feat(collector-chart): add extraEnvFrom support * chore(examples): adding examples * bump operator (open-telemetry#823) * bump collector (open-telemetry#830) * JAC: fix checksum config in statefulset template (open-telemetry#827) * Adds short usage instructions to UPGRADING.md (open-telemetry#826) * Adds short usage instructions to UPGRADING.md * Updated chart version and regenerated examples * Bump operator (open-telemetry#832) * Fix typo in README.md (open-telemetry#831) * Add new helm command to README.md, fix typos (open-telemetry#836) * Add new helm command to README.md, fix typos + Add link to logging exporter * bump operator chart version * Revert "bump operator chart version" This reverts commit 91430ff. * bump operator patch version * Add externalTrafficPolicy value for service type LoadBalancer (open-telemetry#838) Signed-off-by: Alban HURTAUD <alban.hurtaud@amadeus.com> * [collector] Respect pipeline order when enabling kubernetesAttributes (open-telemetry#844) * fix pipeline order when enabling k8sattributes * bump collector and document breakage * kubernetesAttributes example * regenerate examples * Update charts/opentelemetry-collector/UPGRADING.md Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * [collector] Allow disabling service even for deployment and statefulset (open-telemetry#843) * Allow disabling all ports * temp * generate examples * Bump version * bump collector to 0.82.0 (open-telemetry#847) * charts/opentelemetry-collector: recommended CPU limit pushes just over threshold (open-telemetry#851) * charts/opentelemetry-collector: fix CPU limit While "256m" is a valid setting, the intention was likely to allow 4 pods to be scheduled on a single CPU, which we will currently overshoot by 24/1000, since there are only 1000 units in a CPU fraction. Adjust to "250m", which would allow exactly 4 pods to share a CPU. See e.g. https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-cpu * Update charts/opentelemetry-collector/values.yaml Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * Upgrade operator to v0.82.0 (open-telemetry#854) * Upgrade operator to v0.82.0 * ci: fix operator E2E tests * [collector] Allow disabling all ports (open-telemetry#842) * Allow disabling all ports * bump patch version instead * chore(demo): update chart dependencies (open-telemetry#856) * update chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * Bump collector version (open-telemetry#861) * Update clusterrole (open-telemetry#860) * mode: daemonset example indicates hostNetwork: true is required (open-telemetry#849) * add more extraction to preset (open-telemetry#867) * bump operator version to 0.83.0 (open-telemetry#874) * [collector] Update readme (open-telemetry#875) * Update readme with all presets * Add generic list reminder * [collector] Update readme and preset comments (open-telemetry#876) * Update readme and preset comments * Add links to docs from values.yaml * Add missed links * [collector] Make it possible to specify namespace when running Helm template (open-telemetry#871) * bump collector to 0.84.0 (open-telemetry#883) * [collector] limit prometheus rules to opentelemetrycollector application (open-telemetry#885) Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com> * [demo] Use k8sattributesprocessor instead of env vars (open-telemetry#817) * [demo] Use k8sattributesprocessor instead of env vars Signed-off-by: Goutham <gouthamve@gmail.com> * Add 0.24 to upgrading.md Signed-off-by: Goutham <gouthamve@gmail.com> * Update charts/opentelemetry-demo/UPGRADING.md --------- Signed-off-by: Goutham <gouthamve@gmail.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * Bump collector to 0.85.0 (open-telemetry#890) * [operator]: Update UPGRADING.md (open-telemetry#886) (open-telemetry#888) * Bump actions/checkout from 3 to 4 (open-telemetry#884) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [demo] - update for 1.5 release (open-telemetry#873) * update chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * use frontendProxy for all communication Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * demo 1.5 release Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * demo 1.5 release Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * demo 1.5 release Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * demo 1.5 release Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * (demo): update chart dependencies (open-telemetry#893) * update demo chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update demo chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * [operator] bump operator to 0.84.0 (open-telemetry#894) * update environment variable reference (open-telemetry#898) * bump operator to 0.85.0 (open-telemetry#896) * Bump collector to 0.86.0 (open-telemetry#897) * update charts to use debug exporter (open-telemetry#892) * update charts to use debug exporter The logging exporter is being deprecated in favour of the debug exporter. This changes the charts to use that exporter instead. Note: this will remain in draft until v0.86.0 is released which will be the first release to include the debug exporter. Signed-off-by: Alex Boten <aboten@lightstep.com> * make generate-examples CHARTS=opentelemetry-collector Signed-off-by: Alex Boten <aboten@lightstep.com> * update charts Signed-off-by: Alex Boten <aboten@lightstep.com> * revert demo charts Signed-off-by: Alex Boten <aboten@lightstep.com> * bump version for collector/operator charts Signed-off-by: Alex Boten <aboten@lightstep.com> * patch bump Signed-off-by: Alex Boten <aboten@lightstep.com> --------- Signed-off-by: Alex Boten <aboten@lightstep.com> * update prometheus to use otlp write (open-telemetry#901) Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * [demo] Bump collector chart dep (open-telemetry#903) * Bump collector chart * bump version * Switch to tail mode for logsCollection preset (open-telemetry#904) * (demo): update grafana dashboards (open-telemetry#902) * update grafana dashboards Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update grafana dashboards Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * [collector] re-add the logging exporter config (open-telemetry#907) * re-add the logging exporter config * Add warning in NOTES.txt * [collector] Remove deprecated fields (open-telemetry#908) * Remove deprecated fields * update resources warning * [collector] Add ability to enable GOMEMLIMIT (open-telemetry#900) * Add ability to enable GOMEMLIMIT * remove trailing spaces * Fix title * Update charts/opentelemetry-collector/UPGRADING.md Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> * Update charts/opentelemetry-collector/UPGRADING.md Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> * update warning * Cleanup merge * Apply suggestions from code review Co-authored-by: Jina Jain <jjain@splunk.com> --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> Co-authored-by: Jina Jain <jjain@splunk.com> * fix GOMEMLIMIT wrong unit (open-telemetry#913) * [opentelemetry-operator] Add affinity, tolerations and nodeSelector to tests (open-telemetry#911) * Add affinity, tolerations and nodeSelector to tests * Change version from 0.40.0 to 0.39.2 * Generate release notes (open-telemetry#916) * bump collector version to 0.87.0 (open-telemetry#917) * fix prometheus endpoint (open-telemetry#920) Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * [operator] bump to 0.86.0 (open-telemetry#919) * (demo) fix jaeger spm and prometheus config (open-telemetry#922) * fix jaeger spm and prom config Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * fix jaeger spm and prom config Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * [otel-demo] Include namespace in NOTES.txt (open-telemetry#925) * Include namespace in NOTES.txt For full copy & paste, the port-forwarding instructions need to include the namespace. * Bump version && regenerate examples * [otel-demo] Fix exporter environment variable (open-telemetry#927) * bump operator version (open-telemetry#926) * Bump collector to 0.88.0 (open-telemetry#935) * [collector] Update prometheus alerts (open-telemetry#933) * upgrade to 0.88 include bridge (open-telemetry#938) * upgrade to 0.88 include bridge * facepalm * Fix testing action * version fix * update schema * add rbac for bridges * Rename * install prom CRDs for operator e2e tests * Fix prometheuscr test * [demo] add replicas support (open-telemetry#934) * add replicas support Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * note about replicas setting for postgres, kafka, and redis Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * [demo] update to demo 1.6 (open-telemetry#942) * update to demo 1.6 Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update to demo 1.6 Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update to demo 1.6 Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * Bump helm/chart-releaser-action from 1.5.0 to 1.6.0 (open-telemetry#944) Bumps [helm/chart-releaser-action](https://github.com/helm/chart-releaser-action) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/helm/chart-releaser-action/releases) - [Commits](helm/chart-releaser-action@v1.5.0...v1.6.0) --- updated-dependencies: - dependency-name: helm/chart-releaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update clusterrole.yaml (open-telemetry#947) * Adding namespace scope to webhook config (open-telemetry#940) * add option to reuse previously auto-generated cert (open-telemetry#936) * add option to reuse previously auto-generated cert * bump chart version * autoGenerateCert as object with enabled, ifNotExists properties * value renamed, ca in secret, logic moved to _helper * fix default value * Update upgrade guidelines * update UPGRADING.md doc * remove unused file * Bump collector version to 0.89.0 (open-telemetry#955) * [CHORE] adding eBPF helm chart (open-telemetry#855) * [CHORE] adding eBPF helm chart Signed-off-by: Nicolas Takashi <nicolas.tcs@hotmail.com> * Update .github/workflows/ebpf-test.yaml Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * Update charts/opentelemetry-ebpf/Chart.yaml Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * Update CONTRIBUTING.md Co-authored-by: Jared Tan <jian.tan@daocloud.io> * Update CONTRIBUTING.md Co-authored-by: Jared Tan <jian.tan@daocloud.io> * Update CONTRIBUTING.md Co-authored-by: Jared Tan <jian.tan@daocloud.io> * Update README.md Co-authored-by: Jared Tan <jian.tan@daocloud.io> * Update README.md Co-authored-by: Jared Tan <jian.tan@daocloud.io> * Update README.md Co-authored-by: Jared Tan <jian.tan@daocloud.io> * Update charts/opentelemetry-ebpf/CONTRIBUTING.md * Update charts/opentelemetry-ebpf/values.yaml * Update charts/opentelemetry-ebpf/values.yaml Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> --------- Signed-off-by: Nicolas Takashi <nicolas.tcs@hotmail.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> Co-authored-by: Jared Tan <jian.tan@daocloud.io> Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> * [BUMP] Operator v0.89.0/kube-rbac-proxy v0.15.0 (open-telemetry#963) * [BUMP] Operator v0.89.0/kube-rbac-proxy v0.15.0 * fix * Add JaredTan95 to approvers list (open-telemetry#965) * [collector] fix clusterrolebinding binding wrong namespace (open-telemetry#960) * fix clusterrolebinding binding wrong namespace * remove examples --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * [collector] support add additionalLabels for otel col resources (open-telemetry#968) * support add additionalLabels for all resources * add comments * Update charts/opentelemetry-collector/values.yaml Co-authored-by: Jina Jain <jjain@splunk.com> * add comments * Update charts/opentelemetry-collector/values.yaml Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> --------- Co-authored-by: Jina Jain <jjain@splunk.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * Bump collector to 0.90.0 (open-telemetry#972) * Add k8s infra monitorig demo example (open-telemetry#967) * Add k8s infra monitorig demo example Signed-off-by: ChrsMark <chrismarkou92@gmail.com> * Upgrade chart version Signed-off-by: ChrsMark <chrismarkou92@gmail.com> * Bump patch version instead of minor Signed-off-by: ChrsMark <chrismarkou92@gmail.com> --------- Signed-off-by: ChrsMark <chrismarkou92@gmail.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * Bump collector to 0.90.1 (open-telemetry#975) * Make the service port for the webhook configurable (open-telemetry#976) * make the service port for the webhook configurable * service port * version bump * version bump the examples * enable useGOMEMLIMIT by default (open-telemetry#977) * Bump operator to 0.90.0 (open-telemetry#979) * Bump operator to 0.90.0 * Fix E2E test runner in CI * Bump actions/stale from 8 to 9 (open-telemetry#978) Bumps [actions/stale](https://github.com/actions/stale) from 8 to 9. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v8...v9) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [opentelemetry-collector] update collector to v0.91.0 (open-telemetry#981) --------- Signed-off-by: Goutham <gouthamve@gmail.com> Signed-off-by: Alban HURTAUD <alban.hurtaud@amadeus.com> Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Alex Boten <aboten@lightstep.com> Signed-off-by: Nicolas Takashi <nicolas.tcs@hotmail.com> Signed-off-by: ChrsMark <chrismarkou92@gmail.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> Co-authored-by: Goutham Veeramachaneni <gouthamve+github@gmail.com> Co-authored-by: PaoloGallina <paologallina1992@gmail.com> Co-authored-by: Jorge Andreu Calatayud <11544239+jorgeancal@users.noreply.github.com> Co-authored-by: Peter Kern <peter@nomagic.net> Co-authored-by: Jan Katins <jasc@gmx.net> Co-authored-by: Marcin Ziółkowski <62351083+MA3CIN@users.noreply.github.com> Co-authored-by: Alban Hurtaud <alban.hurtaud@amadeus.com> Co-authored-by: Jakob Demler <jakob.demler@jedox.com> Co-authored-by: Kevin Burke <kevin.burke@segment.com> Co-authored-by: Mikołaj Świątek <mail+sumo@mikolajswiatek.com> Co-authored-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Mitch <mitch@yottled.com> Co-authored-by: Krisztian Fekete <103492698+krisztianfekete@users.noreply.github.com> Co-authored-by: André Águas <abaguas@users.noreply.github.com> Co-authored-by: Goutham Veeramachaneni <gouthamve@gmail.com> Co-authored-by: galen-reltio <104534108+galen-reltio@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Boten <alex@boten.ca> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> Co-authored-by: Jina Jain <jjain@splunk.com> Co-authored-by: Jared Tan <jian.tan@daocloud.io> Co-authored-by: Julia Jia <juliajster@gmail.com> Co-authored-by: Marco Aurelio Caldas Miranda <17923899+macmiranda@users.noreply.github.com> Co-authored-by: Cedric Ziel <cedric@cedric-ziel.com> Co-authored-by: Alex <birca@adobe.com> Co-authored-by: Jacob Aronoff <jaronoff97@users.noreply.github.com> Co-authored-by: Abhishek <abhishek.kothari@segment.com> Co-authored-by: Grétar Hauksson <31700328+b3ndill@users.noreply.github.com> Co-authored-by: Tomasz Prus <tomasz.prus@gmail.com> Co-authored-by: Nicolas Takashi <nicolas.tcs@hotmail.com> Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
povilasv
added a commit
to coralogix/opentelemetry-helm-charts
that referenced
this pull request
Feb 9, 2024
* Bump collector version to 0.80.0 (open-telemetry#815) * [opentelemetry-collector] recombine cri multi-line logs (open-telemetry#818) * [demo] Bump OTel Collector chart version (open-telemetry#821) See: open-telemetry#817 (comment) Signed-off-by: Goutham <gouthamve@gmail.com> * Feat/extra env from (open-telemetry#820) * feat(collector-chart): add extraEnvFrom support * chore(examples): adding examples * bump operator (open-telemetry#823) * bump collector (open-telemetry#830) * JAC: fix checksum config in statefulset template (open-telemetry#827) * Adds short usage instructions to UPGRADING.md (open-telemetry#826) * Adds short usage instructions to UPGRADING.md * Updated chart version and regenerated examples * Bump operator (open-telemetry#832) * Fix typo in README.md (open-telemetry#831) * Add new helm command to README.md, fix typos (open-telemetry#836) * Add new helm command to README.md, fix typos + Add link to logging exporter * bump operator chart version * Revert "bump operator chart version" This reverts commit 91430ff. * bump operator patch version * Add externalTrafficPolicy value for service type LoadBalancer (open-telemetry#838) Signed-off-by: Alban HURTAUD <alban.hurtaud@amadeus.com> * [collector] Respect pipeline order when enabling kubernetesAttributes (open-telemetry#844) * fix pipeline order when enabling k8sattributes * bump collector and document breakage * kubernetesAttributes example * regenerate examples * Update charts/opentelemetry-collector/UPGRADING.md Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * [collector] Allow disabling service even for deployment and statefulset (open-telemetry#843) * Allow disabling all ports * temp * generate examples * Bump version * bump collector to 0.82.0 (open-telemetry#847) * charts/opentelemetry-collector: recommended CPU limit pushes just over threshold (open-telemetry#851) * charts/opentelemetry-collector: fix CPU limit While "256m" is a valid setting, the intention was likely to allow 4 pods to be scheduled on a single CPU, which we will currently overshoot by 24/1000, since there are only 1000 units in a CPU fraction. Adjust to "250m", which would allow exactly 4 pods to share a CPU. See e.g. https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-cpu * Update charts/opentelemetry-collector/values.yaml Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * Upgrade operator to v0.82.0 (open-telemetry#854) * Upgrade operator to v0.82.0 * ci: fix operator E2E tests * [collector] Allow disabling all ports (open-telemetry#842) * Allow disabling all ports * bump patch version instead * chore(demo): update chart dependencies (open-telemetry#856) * update chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * Bump collector version (open-telemetry#861) * Update clusterrole (open-telemetry#860) * mode: daemonset example indicates hostNetwork: true is required (open-telemetry#849) * add more extraction to preset (open-telemetry#867) * bump operator version to 0.83.0 (open-telemetry#874) * [collector] Update readme (open-telemetry#875) * Update readme with all presets * Add generic list reminder * [collector] Update readme and preset comments (open-telemetry#876) * Update readme and preset comments * Add links to docs from values.yaml * Add missed links * [collector] Make it possible to specify namespace when running Helm template (open-telemetry#871) * bump collector to 0.84.0 (open-telemetry#883) * [collector] limit prometheus rules to opentelemetrycollector application (open-telemetry#885) Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com> * [demo] Use k8sattributesprocessor instead of env vars (open-telemetry#817) * [demo] Use k8sattributesprocessor instead of env vars Signed-off-by: Goutham <gouthamve@gmail.com> * Add 0.24 to upgrading.md Signed-off-by: Goutham <gouthamve@gmail.com> * Update charts/opentelemetry-demo/UPGRADING.md --------- Signed-off-by: Goutham <gouthamve@gmail.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * Bump collector to 0.85.0 (open-telemetry#890) * [operator]: Update UPGRADING.md (open-telemetry#886) (open-telemetry#888) * Bump actions/checkout from 3 to 4 (open-telemetry#884) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [demo] - update for 1.5 release (open-telemetry#873) * update chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * use frontendProxy for all communication Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * demo 1.5 release Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * demo 1.5 release Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * demo 1.5 release Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * demo 1.5 release Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * (demo): update chart dependencies (open-telemetry#893) * update demo chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update demo chart dependencies Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * [operator] bump operator to 0.84.0 (open-telemetry#894) * update environment variable reference (open-telemetry#898) * bump operator to 0.85.0 (open-telemetry#896) * Bump collector to 0.86.0 (open-telemetry#897) * update charts to use debug exporter (open-telemetry#892) * update charts to use debug exporter The logging exporter is being deprecated in favour of the debug exporter. This changes the charts to use that exporter instead. Note: this will remain in draft until v0.86.0 is released which will be the first release to include the debug exporter. Signed-off-by: Alex Boten <aboten@lightstep.com> * make generate-examples CHARTS=opentelemetry-collector Signed-off-by: Alex Boten <aboten@lightstep.com> * update charts Signed-off-by: Alex Boten <aboten@lightstep.com> * revert demo charts Signed-off-by: Alex Boten <aboten@lightstep.com> * bump version for collector/operator charts Signed-off-by: Alex Boten <aboten@lightstep.com> * patch bump Signed-off-by: Alex Boten <aboten@lightstep.com> --------- Signed-off-by: Alex Boten <aboten@lightstep.com> * update prometheus to use otlp write (open-telemetry#901) Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * [demo] Bump collector chart dep (open-telemetry#903) * Bump collector chart * bump version * Switch to tail mode for logsCollection preset (open-telemetry#904) * (demo): update grafana dashboards (open-telemetry#902) * update grafana dashboards Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update grafana dashboards Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * [collector] re-add the logging exporter config (open-telemetry#907) * re-add the logging exporter config * Add warning in NOTES.txt * [collector] Remove deprecated fields (open-telemetry#908) * Remove deprecated fields * update resources warning * [collector] Add ability to enable GOMEMLIMIT (open-telemetry#900) * Add ability to enable GOMEMLIMIT * remove trailing spaces * Fix title * Update charts/opentelemetry-collector/UPGRADING.md Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> * Update charts/opentelemetry-collector/UPGRADING.md Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> * update warning * Cleanup merge * Apply suggestions from code review Co-authored-by: Jina Jain <jjain@splunk.com> --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> Co-authored-by: Jina Jain <jjain@splunk.com> * fix GOMEMLIMIT wrong unit (open-telemetry#913) * [opentelemetry-operator] Add affinity, tolerations and nodeSelector to tests (open-telemetry#911) * Add affinity, tolerations and nodeSelector to tests * Change version from 0.40.0 to 0.39.2 * Generate release notes (open-telemetry#916) * bump collector version to 0.87.0 (open-telemetry#917) * fix prometheus endpoint (open-telemetry#920) Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * [operator] bump to 0.86.0 (open-telemetry#919) * (demo) fix jaeger spm and prometheus config (open-telemetry#922) * fix jaeger spm and prom config Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * fix jaeger spm and prom config Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * [otel-demo] Include namespace in NOTES.txt (open-telemetry#925) * Include namespace in NOTES.txt For full copy & paste, the port-forwarding instructions need to include the namespace. * Bump version && regenerate examples * [otel-demo] Fix exporter environment variable (open-telemetry#927) * bump operator version (open-telemetry#926) * Bump collector to 0.88.0 (open-telemetry#935) * [collector] Update prometheus alerts (open-telemetry#933) * upgrade to 0.88 include bridge (open-telemetry#938) * upgrade to 0.88 include bridge * facepalm * Fix testing action * version fix * update schema * add rbac for bridges * Rename * install prom CRDs for operator e2e tests * Fix prometheuscr test * [demo] add replicas support (open-telemetry#934) * add replicas support Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * note about replicas setting for postgres, kafka, and redis Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * [demo] update to demo 1.6 (open-telemetry#942) * update to demo 1.6 Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update to demo 1.6 Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update to demo 1.6 Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * Bump helm/chart-releaser-action from 1.5.0 to 1.6.0 (open-telemetry#944) Bumps [helm/chart-releaser-action](https://github.com/helm/chart-releaser-action) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/helm/chart-releaser-action/releases) - [Commits](helm/chart-releaser-action@v1.5.0...v1.6.0) --- updated-dependencies: - dependency-name: helm/chart-releaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update clusterrole.yaml (open-telemetry#947) * Adding namespace scope to webhook config (open-telemetry#940) * add option to reuse previously auto-generated cert (open-telemetry#936) * add option to reuse previously auto-generated cert * bump chart version * autoGenerateCert as object with enabled, ifNotExists properties * value renamed, ca in secret, logic moved to _helper * fix default value * Update upgrade guidelines * update UPGRADING.md doc * remove unused file * Bump collector version to 0.89.0 (open-telemetry#955) * [CHORE] adding eBPF helm chart (open-telemetry#855) * [CHORE] adding eBPF helm chart Signed-off-by: Nicolas Takashi <nicolas.tcs@hotmail.com> * Update .github/workflows/ebpf-test.yaml Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * Update charts/opentelemetry-ebpf/Chart.yaml Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * Update CONTRIBUTING.md Co-authored-by: Jared Tan <jian.tan@daocloud.io> * Update CONTRIBUTING.md Co-authored-by: Jared Tan <jian.tan@daocloud.io> * Update CONTRIBUTING.md Co-authored-by: Jared Tan <jian.tan@daocloud.io> * Update README.md Co-authored-by: Jared Tan <jian.tan@daocloud.io> * Update README.md Co-authored-by: Jared Tan <jian.tan@daocloud.io> * Update README.md Co-authored-by: Jared Tan <jian.tan@daocloud.io> * Update charts/opentelemetry-ebpf/CONTRIBUTING.md * Update charts/opentelemetry-ebpf/values.yaml * Update charts/opentelemetry-ebpf/values.yaml Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> --------- Signed-off-by: Nicolas Takashi <nicolas.tcs@hotmail.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> Co-authored-by: Jared Tan <jian.tan@daocloud.io> Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> * [BUMP] Operator v0.89.0/kube-rbac-proxy v0.15.0 (open-telemetry#963) * [BUMP] Operator v0.89.0/kube-rbac-proxy v0.15.0 * fix * Add JaredTan95 to approvers list (open-telemetry#965) * [collector] fix clusterrolebinding binding wrong namespace (open-telemetry#960) * fix clusterrolebinding binding wrong namespace * remove examples --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * [collector] support add additionalLabels for otel col resources (open-telemetry#968) * support add additionalLabels for all resources * add comments * Update charts/opentelemetry-collector/values.yaml Co-authored-by: Jina Jain <jjain@splunk.com> * add comments * Update charts/opentelemetry-collector/values.yaml Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> --------- Co-authored-by: Jina Jain <jjain@splunk.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * Bump collector to 0.90.0 (open-telemetry#972) * Add k8s infra monitorig demo example (open-telemetry#967) * Add k8s infra monitorig demo example Signed-off-by: ChrsMark <chrismarkou92@gmail.com> * Upgrade chart version Signed-off-by: ChrsMark <chrismarkou92@gmail.com> * Bump patch version instead of minor Signed-off-by: ChrsMark <chrismarkou92@gmail.com> --------- Signed-off-by: ChrsMark <chrismarkou92@gmail.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * Bump collector to 0.90.1 (open-telemetry#975) * Make the service port for the webhook configurable (open-telemetry#976) * make the service port for the webhook configurable * service port * version bump * version bump the examples * enable useGOMEMLIMIT by default (open-telemetry#977) * Bump operator to 0.90.0 (open-telemetry#979) * Bump operator to 0.90.0 * Fix E2E test runner in CI * Bump actions/stale from 8 to 9 (open-telemetry#978) Bumps [actions/stale](https://github.com/actions/stale) from 8 to 9. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v8...v9) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [opentelemetry-collector] update collector to v0.91.0 (open-telemetry#981) * Set Port for the webhook (open-telemetry#982) * Set webhook port correctly * whoops * [opentelemetry-operator] remove default limits for cpu and memory (open-telemetry#970) * [opentelemetry-operator] remove default limits for cpu and memory * adjusted schema and ran make commands * Updated documentation Signed-off-by: Pieter van der Giessen <pieter@pionative.com> --------- Signed-off-by: Pieter van der Giessen <pieter@pionative.com> * [demo] update to demo release 1.7 (open-telemetry#983) * update to demo 1.7 Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update to demo 1.7 Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * polish otel operator WebhookCert logical (open-telemetry#986) * [operator] fix readme (open-telemetry#987) * fix readme * bump chart version * bump collector to 0.92.0 (open-telemetry#991) * [operator] Bump operator version to 0.91.0 (open-telemetry#989) * Bump operator version * update crds * bump collector version (open-telemetry#993) * Use appVersion by default (open-telemetry#994) * fix grafana dashboards (open-telemetry#1000) Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * [collector] Enable `retry_on_failure` for filelog receiver created by logsCollection preset (open-telemetry#999) * enable filelog with retry_on_failure as default config Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com> * enable filelog with retry_on_failure as default config Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com> --------- Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * demo: add missing namespace on grafana dashboard (open-telemetry#1002) * demo: add missing namespace on grafana dashboard fixes: open-telemetry#1001 Signed-off-by: hsinhoyeh <yhh92u@gmail.com> * add rendered yamls Signed-off-by: hsinhoyeh <yhh92u@gmail.com> --------- Signed-off-by: hsinhoyeh <yhh92u@gmail.com> * [operator] Bump operator version to 0.92.1 (open-telemetry#998) * Bump operator version to 0.92.0 * update cluster role * generate examples * Bump to 0.92.1 * Revert "update cluster role" This reverts commit 7f43569. * regenerate * [collector] Enable HPA when deploy mode is statefulset (open-telemetry#1011) * [collector] Enable HPA when deploy mode is statefulset Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com> * [collector] Enable HPA when deploy mode is statefulset Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com> * Add test scenario for HPA of deployment and statefulset Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com> --------- Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com> * [demo] add mountedConfigMaps support (open-telemetry#1007) * add mountedConfigMaps support Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add mountedConfigMaps support Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add mountedConfigMaps support Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add mountedConfigMaps support Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Jared Tan <jian.tan@daocloud.io> * explicitly set healthcheck extension endpoint (open-telemetry#1012) * [opentelemetry-collector] Fix calculation for gomemlimit (open-telemetry#1015) * set gomemlimit correctly * minor fixes * update chart version * update var * remove unittest * remove unittest * [collector] bump appVersion to 0.93.0 (open-telemetry#1018) * Allow for secure deployments by default. (open-telemetry#1019) * Allow for secure deployments by default. * Restored data added during testing to original state. * Updated demo chart README.md. * Added additional comments to values.yaml to illustrate how the new feature can be used. * Executed "make generate-examples" and pushing results. * [opentelemetry-collector] fix HPA kind for StatefulSet mode (open-telemetry#1025) * add helper to set kind in HPA * update autoscaling comment in values * bump version * [operator] Bump operator to 0.93.0 (open-telemetry#1027) * bump operator to 0.93.0 * Update collector version --------- Signed-off-by: Goutham <gouthamve@gmail.com> Signed-off-by: Alban HURTAUD <alban.hurtaud@amadeus.com> Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Alex Boten <aboten@lightstep.com> Signed-off-by: Nicolas Takashi <nicolas.tcs@hotmail.com> Signed-off-by: ChrsMark <chrismarkou92@gmail.com> Signed-off-by: Pieter van der Giessen <pieter@pionative.com> Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com> Signed-off-by: hsinhoyeh <yhh92u@gmail.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> Co-authored-by: Goutham Veeramachaneni <gouthamve+github@gmail.com> Co-authored-by: PaoloGallina <paologallina1992@gmail.com> Co-authored-by: Jorge Andreu Calatayud <11544239+jorgeancal@users.noreply.github.com> Co-authored-by: Peter Kern <peter@nomagic.net> Co-authored-by: Jan Katins <jasc@gmx.net> Co-authored-by: Marcin Ziółkowski <62351083+MA3CIN@users.noreply.github.com> Co-authored-by: Alban Hurtaud <alban.hurtaud@amadeus.com> Co-authored-by: Jakob Demler <jakob.demler@jedox.com> Co-authored-by: Kevin Burke <kevin.burke@segment.com> Co-authored-by: Mikołaj Świątek <mail+sumo@mikolajswiatek.com> Co-authored-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Mitch <mitch@yottled.com> Co-authored-by: Krisztian Fekete <103492698+krisztianfekete@users.noreply.github.com> Co-authored-by: André Águas <abaguas@users.noreply.github.com> Co-authored-by: Goutham Veeramachaneni <gouthamve@gmail.com> Co-authored-by: galen-reltio <104534108+galen-reltio@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Boten <alex@boten.ca> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> Co-authored-by: Jina Jain <jjain@splunk.com> Co-authored-by: Jared Tan <jian.tan@daocloud.io> Co-authored-by: Julia Jia <juliajster@gmail.com> Co-authored-by: Marco Aurelio Caldas Miranda <17923899+macmiranda@users.noreply.github.com> Co-authored-by: Cedric Ziel <cedric@cedric-ziel.com> Co-authored-by: Alex <birca@adobe.com> Co-authored-by: Jacob Aronoff <jaronoff97@users.noreply.github.com> Co-authored-by: Abhishek <abhishek.kothari@segment.com> Co-authored-by: Grétar Hauksson <31700328+b3ndill@users.noreply.github.com> Co-authored-by: Tomasz Prus <tomasz.prus@gmail.com> Co-authored-by: Nicolas Takashi <nicolas.tcs@hotmail.com> Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> Co-authored-by: Chris Mark <chrismarkou92@gmail.com> Co-authored-by: Pieter <110168856+Pionerd@users.noreply.github.com> Co-authored-by: Husni Alhamdani <dhanielluis@gmail.com> Co-authored-by: hsinhoyeh <yhh92u@gmail.com> Co-authored-by: Louis Parkin <11991882+LouisParkin@users.noreply.github.com> Co-authored-by: Alexander Lindeskär <lindeskar@users.noreply.github.com>
12ushan
pushed a commit
to giffgaff/opentelemetry-helm-charts
that referenced
this pull request
Jul 22, 2024
…r threshold (open-telemetry#851) * charts/opentelemetry-collector: fix CPU limit While "256m" is a valid setting, the intention was likely to allow 4 pods to be scheduled on a single CPU, which we will currently overshoot by 24/1000, since there are only 1000 units in a CPU fraction. Adjust to "250m", which would allow exactly 4 pods to share a CPU. See e.g. https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-cpu * Update charts/opentelemetry-collector/values.yaml Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While "256m" is a valid setting, the intention was likely to allow 4 pods to be scheduled on a single CPU, which we will currently overshoot by 24/1000, since there are only 1000 units in a CPU fraction.
Adjust to "250m", which would allow exactly 4 pods to share a CPU.
See e.g. https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-cpu