Move class that should've been internal to internal package (#9725)

open-telemetry · Oct 20, 2023 · 0ec55db · 0ec55db
1 parent 93e0667
commit 0ec55db
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/...metry/instrumentation/api/instrumenter/http/HttpClientPeerServiceAttributesExtractor.java b/...metry/instrumentation/api/instrumenter/http/HttpClientPeerServiceAttributesExtractor.java
@@ -9,7 +9,7 @@
 import io.opentelemetry.context.Context;
 import io.opentelemetry.instrumentation.api.instrumenter.AttributesExtractor;
 import io.opentelemetry.instrumentation.api.instrumenter.net.PeerServiceResolver;
-import io.opentelemetry.instrumentation.api.instrumenter.url.UrlParser;
+import io.opentelemetry.instrumentation.api.instrumenter.net.internal.UrlParser;
 import io.opentelemetry.instrumentation.api.internal.SemconvStability;
 import io.opentelemetry.semconv.SemanticAttributes;
 import java.util.function.Supplier;

diff --git a/...n/java/io/opentelemetry/instrumentation/api/instrumenter/net/PeerServiceResolverImpl.java b/...n/java/io/opentelemetry/instrumentation/api/instrumenter/net/PeerServiceResolverImpl.java
@@ -10,7 +10,7 @@
 import static java.util.Comparator.nullsFirst;
 
 import com.google.auto.value.AutoValue;
-import io.opentelemetry.instrumentation.api.instrumenter.url.UrlParser;
+import io.opentelemetry.instrumentation.api.instrumenter.net.internal.UrlParser;
 import java.util.Comparator;
 import java.util.HashMap;
 import java.util.Map;

diff --git a/...ation/api/instrumenter/url/UrlParser.java → .../instrumenter/net/internal/UrlParser.java b/...ation/api/instrumenter/url/UrlParser.java → .../instrumenter/net/internal/UrlParser.java
@@ -3,12 +3,16 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-package io.opentelemetry.instrumentation.api.instrumenter.url;
+package io.opentelemetry.instrumentation.api.instrumenter.net.internal;
 
 import java.util.function.Predicate;
 import javax.annotation.Nullable;
 
-public class UrlParser {
+/**
+ * This class is internal and is hence not for public use. Its APIs are unstable and can change at
+ * any time.
+ */
+public final class UrlParser {
 
   @Nullable
   public static String getHost(String url) {

diff --git a/...nv/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/url/UrlParserTest.java b/...nv/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/url/UrlParserTest.java
@@ -7,6 +7,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
+import io.opentelemetry.instrumentation.api.instrumenter.net.internal.UrlParser;
 import org.junit.jupiter.api.Test;
 
 class UrlParserTest {