Disable sporadically failing test #10570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Feb 16, 2024
| @@ -154,10 +151,11 @@ private static Stream<Arguments> provideReactiveParameters() { | |||
| "users")))); | |||
| } | |||
|
|
|||
| @Override | |||
| protected CqlSessionBuilder addContactPoint(CqlSessionBuilder sessionBuilder) { | |||
There was a problem hiding this comment.
I think we have seen something similar before. I suspect that the issue in in docker/testcontainers network magic where local ip addresses are added/removed by the tests. Probably here it ends up connecting to one of these addresses (or perhaps even an address that just got removed?). As the exception only logs the endpoint we don't see where it actually tried to connect. I'd try
sessionBuilder.addContactEndPoint(new SniEndPoint(address, "localhost") {
@Override
public InetSocketAddress resolve() {
return address;
}
});
laurit
approved these changes
Feb 16, 2024
steverao
pushed a commit
to steverao/opentelemetry-java-instrumentation
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10562
cc @heyams
I think it's ok not to test SniEndpoint since that wasn't really the purpose of #10357 anyways