Move shaded testing dependencies to internal package. #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
trask
reviewed
Jun 15, 2021
| import io.opentelemetry.testing.armeria.client.WebClient | ||
| import io.opentelemetry.testing.internal.armeria.client.WebClient |
There was a problem hiding this comment.
what's the purpose of moving these to internal package if they still have external usages? or is this a first step?
There was a problem hiding this comment.
By external usage do you mean the usages in this repo? internal is fine to use in this repo, similar to the internal package being used across artifacts in the opentelemetry-java repo. The purpose is to make them unsupported for use from consumers of the testing-common package from Maven Central
trask
approved these changes
Jun 15, 2021
mateuszrzeszutek
approved these changes
Jun 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frameworks we use for HTTP in testing is an implementation detail of our testing-common libraries and our repo's tests, they shouldn't be used directly by users. It's easy enough to bring in a favorite HTTP framework if a downstream repo needs it I think.
I tried moving the dependency from
apitoimplementationat first but remembered Groovy doesn't let you compile a subclass without the parent's dependencies on the compile classpath (grr).