Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only instrument the actual Spring TaskScheduler implementations #8676

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Only instrument the actual Spring TaskScheduler implementations #8676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28cbe23
Only instrument the actual Spring TaskScheduler implementations
Jun 8, 2023
ac53d23
add comment
Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...emetry/javaagent/instrumentation/spring/scheduling/v3_1/TaskSchedulerInstrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

package io.opentelemetry.javaagent.instrumentation.spring.scheduling.v3_1;

import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.implementsInterface;
import static net.bytebuddy.matcher.ElementMatchers.named;
import static net.bytebuddy.matcher.ElementMatchers.namedOneOf;
import static net.bytebuddy.matcher.ElementMatchers.takesArgument;
Expand All @@ -20,7 +19,12 @@
public class TaskSchedulerInstrumentation implements TypeInstrumentation {
@Override
public ElementMatcher<TypeDescription> typeMatcher() {
return implementsInterface(named("org.springframework.scheduling.TaskScheduler"));
// we're only instrumenting the "real" scheduler implementations, and skipping all the decorator
// impls
return namedOneOf(
"org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler",
"org.springframework.scheduling.concurrent.ConcurrentTaskScheduler",
"org.springframework.scheduling.commonj.TimerManagerTaskScheduler");
mateuszrzeszutek marked this conversation as resolved.
Show resolved Hide resolved
}

@Override
Expand Down