Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate and unnecessary code in micrometer1shim #4682

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #4682 (128a39d) into main (dcb9bbb) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #4682      +/-   ##
============================================
+ Coverage     90.08%   90.17%   +0.08%     
  Complexity     5074     5074              
============================================
  Files           584      584              
  Lines         15667    15647      -20     
  Branches       1504     1504              
============================================
- Hits          14114    14109       -5     
+ Misses         1100     1085      -15     
  Partials        453      453              
Impacted Files Coverage Δ
...elemetry/micrometer1shim/OpenTelemetryCounter.java 80.95% <100.00%> (+8.95%) ⬆️
.../micrometer1shim/OpenTelemetryFunctionCounter.java 75.00% <100.00%> (+10.00%) ⬆️
...ry/micrometer1shim/OpenTelemetryFunctionTimer.java 70.00% <100.00%> (+5.29%) ⬆️
...ntelemetry/micrometer1shim/OpenTelemetryGauge.java 73.33% <100.00%> (+10.17%) ⬆️
...ntelemetry/micrometer1shim/OpenTelemetryMeter.java 87.50% <100.00%> (+5.68%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkwatson jkwatson merged commit abbafb3 into open-telemetry:main Aug 12, 2022
@bogdandrutu bogdandrutu deleted the useabstractmeter branch August 12, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants