-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OT Shim] Fully support Baggage-only propagation. #4739
[OT Shim] Fully support Baggage-only propagation. #4739
Conversation
This includes both in-process and inter-process propagation.
Codecov ReportBase: 90.77% // Head: 90.77% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4739 +/- ##
=========================================
Coverage 90.77% 90.77%
- Complexity 4815 4816 +1
=========================================
Files 551 551
Lines 14356 14358 +2
Branches 1395 1395
=========================================
+ Hits 13031 13033 +2
Misses 909 909
Partials 416 416
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanShim.java
Outdated
Show resolved
Hide resolved
Anything else to merge this PR? |
Looks good - Sorry about the delay @carlosalberto! |
Baggage
without a validSpan
should still be properly propagated in inter-process and in-process operations.This is part of the OT compatibility section - essentially, the changes are:
cc @zeitlinger