Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align exemplar filter names with spec #5063

Merged
merged 3 commits into from
Dec 29, 2022

Conversation

jack-berg
Copy link
Member

Resolves #5057.

@jack-berg jack-berg requested a review from a team December 22, 2022 20:43
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 91.24% // Head: 91.24% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4e9f468) compared to base (16a02b2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5063   +/-   ##
=========================================
  Coverage     91.24%   91.24%           
- Complexity     4883     4889    +6     
=========================================
  Files           553      553           
  Lines         14449    14453    +4     
  Branches       1379     1379           
=========================================
+ Hits          13184    13188    +4     
+ Misses          878      876    -2     
- Partials        387      389    +2     
Impacted Files Coverage Δ
.../sdk/autoconfigure/MeterProviderConfiguration.java 100.00% <100.00%> (+21.73%) ⬆️
...telemetry/sdk/metrics/SdkMeterProviderBuilder.java 100.00% <100.00%> (ø)
...sdk/metrics/internal/exemplar/AlwaysOffFilter.java 66.66% <100.00%> (ø)
.../sdk/metrics/internal/exemplar/AlwaysOnFilter.java 66.66% <100.00%> (ø)
.../sdk/metrics/internal/exemplar/ExemplarFilter.java 100.00% <100.00%> (ø)
...cs/internal/exemplar/TraceBasedExemplarFilter.java 100.00% <100.00%> (ø)
...rics/internal/state/AsynchronousMetricStorage.java 93.47% <100.00%> (ø)
...metry/sdk/metrics/export/PeriodicMetricReader.java 87.14% <0.00%> (-2.86%) ⬇️
...telemetry/sdk/trace/export/BatchSpanProcessor.java 91.03% <0.00%> (-2.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit 17e8106 into open-telemetry:main Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename exemplar filter options to match specification
3 participants