Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Java 17 toolchain and fail if not found #6303

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu requested a review from a team March 18, 2024 17:16
Copy link

linux-foundation-easycla bot commented Mar 18, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bogdandrutu / name: Bogdan Drutu (8ca11c3)
  • ✅ login: jack-berg (c961087)

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.04%. Comparing base (b2298ab) to head (c961087).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6303   +/-   ##
=========================================
  Coverage     91.04%   91.04%           
  Complexity     5726     5726           
=========================================
  Files           625      625           
  Lines         16744    16744           
  Branches       1713     1713           
=========================================
  Hits          15244    15244           
  Misses         1006     1006           
  Partials        494      494           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@breedx-splk
Copy link
Contributor

Yeah, we don't want to break users who are already on 21.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a commit which reflects this recommendation: #6303 (comment)

Updated the PR title

@jack-berg jack-berg changed the title Enforce and clarify that Java17 is required Check for Java 17 toolchain and fail if not found Mar 21, 2024
@jack-berg jack-berg merged commit d8f26b2 into open-telemetry:main Mar 21, 2024
18 checks passed
@jord1e
Copy link

jord1e commented Apr 6, 2024

Hi, here from the release notes.

You can actually configure Gradle to install the JDK version that is not present (17 in this case) when it is not found on the local system, this is a better experience than erroring and was the default up to Gradle 7.x or so.
You can keep the check in this PR for sanity.

Just edit settings.gradle(.kts) [NOT build.gradle(.kts)] and add this one line plugin. Here is a snippet:

plugins {
    id 'org.gradle.toolchains.foojay-resolver-convention' version '0.8.0'
}

rootProject.name = 'xxx'

See the official docs: https://docs.gradle.org/current/userguide/toolchains.html#sec:provisioning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants