Refactor ExtendedTracer, ExtendedSpanBuilder to reflect incubating API conventions #6497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtendedTracer, ExtendedSpanBuilder break with the pattern used elsewhere for experimental APIs in that they are implemented using concrete classes instead of as extended versions of the stable interfaces.
This makes it impossible to implement behavior which depends on internal state only accessible from the SDK. Refactoring this so I can add
ExtendedTracer#enabled
with a response that reflects whether the Tracer's scope config is enabled.Also adds working code examples demonstrating the usage, instead of brittle non-compiled examples in the readme.
cc @zeitlinger