chore(instr-perf-tools): update deps to similar versions as other contrib packages

[trentm]

• '@opentelemetry/instrumentation' dep should match others in this repo
• drop the '@types/{mocha,node}' devDeps because I'm not sure they are needed
• reduce 'mocha' dep to v7 used by all other packages
• bump /api peer dep to 1.3.0 (the version when api-metrics was merged into api)

---

• '@opentelemetry/instrumentation' dep should match others in this repo

I actually not sure if this is cargo-culting.

• drop the '@types/{mocha,node}' devDeps because I'm not sure they are needed

Is this wrong? Basically all contrib packages include these two packages as devDeps. Are those @types/... packages needed for IDE usage or something? My "I'm not sure they are needed" is based on running npm run compile && npm test.

[codecov]

Codecov Report

Merging #1967 (ddc4150) into main (44b2df0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1967   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         146      146           
  Lines        7491     7491           
  Branches     1501     1501           
=======================================
  Hits         6819     6819           
  Misses        672      672           

[pichlermarc]

I actually not sure if this is cargo-culting.

• drop the '@types/{mocha,node}' devDeps because I'm not sure they are needed

Is this wrong? Basically all contrib packages include these two packages as devDeps. Are those @types/... packages needed for IDE usage or something? My "I'm not sure they are needed" is based on running npm run compile && npm test.

@types/node is needed for assert, and @types/mocha is needed for describe, beforeEach, ...

For me, at least, my IDE (JetBrains WebStorm) does not complain, but I think that's because it's being hoisted by other packages in the workspace. Removing the package from the workspace, adding lerna, and npm install-ing it causes it not to compile afterward. 🤔

We usually include all devDependencies explicitly in each package as we try to avoid depending on another package's hoisted dependencies as devDependencies. Another goal was to keep single packages npm install-able, speeding up the workflow when working on only one package. I'm not sure if all arguments still hold (I know working on a single package would require at least lerna to be installed which is not listed as a devDependency in packages, but I think that's the only exception to the rule at the moment).

That being said: the decision to do this was made a long time ago - happy to see that revised it if there's a better alternative. Doing so would probably better suited for another PR, though. 🙂

[pichlermarc]

bump /api peer dep to 1.3.0 (the version when api-metrics was merged into api)

👍

reduce 'mocha' dep to v7 used by all other packages

👍

'@opentelemetry/instrumentation' dep should match others in this repo

👍

[trentm]

Replaced by #1994