Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(instrumentation-restify): add ESM test for restify #2149

Conversation

JamieDanielson
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • add use-restify.mjs fixture for testing ESM usage of restify instrumentation
  • add ESM test for restify instrumentation

Also added use-restify.cjs for now to show that instrumentation looks to currently work for CJS but not ESM.

# works, shows span in output
➜  fixtures git:(jamie.restify-esm-test) ✗ node use-restify.cjs
# doesnt work
➜  fixtures git:(jamie.restify-esm-test) ✗ node --experimental-loader=@opentelemetry/instrumentation/hook.mjs use-restify.mjs

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (dfb2dff) to head (bdb89be).
Report is 75 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2149      +/-   ##
==========================================
- Coverage   90.97%   89.21%   -1.77%     
==========================================
  Files         146      105      -41     
  Lines        7492     5590    -1902     
  Branches     1502     1111     -391     
==========================================
- Hits         6816     4987    -1829     
+ Misses        676      603      -73     

see 58 files with indirect coverage changes

@JamieDanielson
Copy link
Member Author

will revisit later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants