-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: version 0.13.0 #316
chore: version 0.13.0 #316
Conversation
Codecov Report
@@ Coverage Diff @@
## main #316 +/- ##
=======================================
Coverage 95.48% 95.48%
=======================================
Files 119 119
Lines 6273 6273
Branches 609 609
=======================================
Hits 5990 5990
Misses 283 283
|
I don't think we should release anything without updating the examples to be up to date. These are the first thing people are testing and it will break and confuse them immediately, not even mentioning that simply checking that it still works fine. We are asking for troubles :/ |
This reverts commit dab01cf.
I'll update examples monday |
@dyladan are you planning to add this yet in this PR or it will be separate PR ? |
this PR. there are a lot of examples and it isn't highest priority. i'm still working on it. |
we can split work if you want, merge this PR, create a new with examples you already have can help with other examples then |
it's fine. the only time consuming part is that the examples reference unpublished versions of the plugins so i have to install them by filepath, verify they work, then switch it back. Most of the examples don't use API directly so they work just fine without modification. |
Examples updated @obecny |
If it's not too late, and not too much to ask, could #318 go into this release? |
I think this should wait for #329 |
Sorry we had a new team member join today so my morning was full of meetings and such. I will release now |
https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/untagged-26002e834d1ea3107c2a