-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otlp-exporter-base
dependency missing from exporter-metrics-otlp-grpc
package.json
#4676
Comments
otlp-exporter-base
dependency missing from `exporter-metrics-otlp-grpc package.jsonotlp-exporter-base
dependency missing from exporter-metrics-otlp-grpc
package.json
@dyladan ? |
No need to ping me directly when creating an issue as I get a notification when it's created |
Looks like this hasn't caused problems so far because otlp-exporter-base is a subdependency so the require doesn't fail. Yarn is more strict about requiring explicit dependencies in package.json. @AkselAllas are you planning to open a PR? |
Marking this as p3 because it is possible to make yarn be less strict with flags, although it is definitely a bug. |
Closed by #4678 |
What happened?
Steps to Reproduce
Do
yarn install
with@opentelemetry/exporter-metrics-otlp-grpc
on version0.51.0
using yarn pnp strict dependency rulesExpected Result
Yarn install works without error
Actual Result
Additional Details
This is caused by
https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/package.json
missing require for
https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/src/OTLPMetricExporter.ts#L35
OpenTelemetry Setup Code
No response
package.json
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered: