Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable debug scopes #1205

Merged

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Jan 8, 2024

Allows disabling debug scopes via OTEL_PHP_DEBUG_SCOPES_DISABLED; resolves #1140 (comment).

@Nevay Nevay requested a review from a team January 8, 2024 13:12
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a196c13) 84.08% compared to head (1f5aecc) 84.09%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1205   +/-   ##
=========================================
  Coverage     84.08%   84.09%           
- Complexity     2237     2239    +2     
=========================================
  Files           285      285           
  Lines          6359     6362    +3     
=========================================
+ Hits           5347     5350    +3     
  Misses         1012     1012           
Flag Coverage Δ
7.4 82.76% <100.00%> (+<0.01%) ⬆️
8.0 84.02% <100.00%> (+<0.01%) ⬆️
8.1 84.15% <100.00%> (+<0.01%) ⬆️
8.2 84.15% <100.00%> (+<0.01%) ⬆️
8.3 84.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Context/Context.php 82.22% <100.00%> (+1.26%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a196c13...1f5aecc. Read the comment docs.

@brettmc brettmc merged commit 82c0f8e into open-telemetry:main Jan 9, 2024
12 of 13 checks passed
@Nevay Nevay deleted the feature/allow-disabling-debug-scope branch January 10, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants