Merge OTELResourceDetector result when creating resources #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
changed the title
aabmass
force-pushed
the
detect-from-env
branch
from
49e0e66
to
60cb0f3
Compare
aabmass
force-pushed
the
detect-from-env
branch
from
60cb0f3
to
ca9f91b
Compare
lzchen
reviewed
Sep 13, 2020
Wouldn't this be a simple addition to this PR? |
Yup it was a note to myself but i forgot, will add it to this PR |
aabmass
force-pushed
the
detect-from-env
branch
from
47b9a2f
to
8a9677e
Compare
lzchen
approved these changes
Sep 16, 2020
alertedsnake
pushed a commit
to alertedsnake/opentelemetry-python
that referenced
this pull request
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge in resources detected from
OTELResourceDetector(which parsesOTEL_RESOURCE_ATTRIBUTES) when a resource is created. Here is the relevant section in the spec. I considered doing this in the module level declaration of_DEFAULT_RESOURCE, but then I'm not sure how to test this with mocking since it runs at import time.Fixes #1063
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
test_resources.pyChecklist: