Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow samplers to modify TraceState #1319

Merged
merged 6 commits into from
Nov 2, 2020
Merged

Allow samplers to modify TraceState #1319

merged 6 commits into from
Nov 2, 2020

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Nov 2, 2020

Fixes #1220

@lzchen lzchen requested review from a team, aabmass and hectorhdzg and removed request for a team November 2, 2020 16:04
aabmass
aabmass approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzchen lzchen merged commit 1662ca9 into open-telemetry:master Nov 2, 2020
@lzchen lzchen deleted the tracestate branch November 2, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

@ocelotl ocelotl ocelotl approved these changes

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow samplers to modify tracestate
3 participants
@lzchen @aabmass @ocelotl