Sanitize resource attribute pairs to avoid exception #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
force-pushed
the
filter-invalid-resource-attributes-pairs
branch
from
8e7f447
to
e9c9649
Compare
NathanielRN
force-pushed
the
filter-invalid-resource-attributes-pairs
branch
from
e9c9649
to
e93d8f4
Compare
NathanielRN
changed the title
srikanthccv
approved these changes
Nov 3, 2021
lzchen
approved these changes
Nov 3, 2021
aabmass
approved these changes
Nov 4, 2021
NathanielRN
force-pushed
the
filter-invalid-resource-attributes-pairs
branch
from
e93d8f4
to
a18facb
Compare
|
@aabmass @lonewolf3739 |
NathanielRN
force-pushed
the
filter-invalid-resource-attributes-pairs
branch
from
a18facb
to
2fb6b61
Compare
aabmass
approved these changes
Nov 8, 2021
NathanielRN
force-pushed
the
filter-invalid-resource-attributes-pairs
branch
from
2fb6b61
to
c1dfa09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sanitze the
OTEL_RESOURCE_ATTRIBUTESenvironment variable for "invalid" key/value pairs so that we do not throw aexception.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added a unit test to for the empty string
""as well as a pair that does not have the=symbol.No.
Checklist:
- [] Documentation has been updated