-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/otlp] add support for Sum #2370
Merged
ocelotl
merged 9 commits into
open-telemetry:main
from
codeboten:codeboten/fill-otlp-metrics-details
Jan 18, 2022
Merged
[exporter/otlp] add support for Sum #2370
ocelotl
merged 9 commits into
open-telemetry:main
from
codeboten:codeboten/fill-otlp-metrics-details
Jan 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocelotl
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only nits 👍
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
...pentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp-proto-grpc/tests/metrics/test_otlp_metrics_exporter.py
Show resolved
Hide resolved
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
aabmass
reviewed
Jan 14, 2022
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
Adding support for exporting Sum datapoints.
codeboten
force-pushed
the
codeboten/fill-otlp-metrics-details
branch
from
January 14, 2022 23:22
ddf3fbf
to
1fa2f94
Compare
aabmass
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment otherwise LGTM
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
aabmass
added
the
Approve Public API check
This label shows that the public symbols added or changed in a PR are strictly necessary
label
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approve Public API check
This label shows that the public symbols added or changed in a PR are strictly necessary
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for exporting Sum datapoints.
Part of #2337
Type of change
Please delete options that are not relevant.
Does This PR Require a Contrib Repo Change?
Checklist: