Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/otlp] add support for Sum #2370

Merged

Conversation

codeboten
Copy link
Contributor

Description

Adding support for exporting Sum datapoints.

Part of #2337

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added

@codeboten codeboten requested a review from a team January 13, 2022 19:47
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nits 👍

Alex Boten added 3 commits January 14, 2022 15:22
@codeboten codeboten force-pushed the codeboten/fill-otlp-metrics-details branch from ddf3fbf to 1fa2f94 Compare January 14, 2022 23:22
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment otherwise LGTM

@aabmass aabmass added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Jan 17, 2022
@ocelotl ocelotl merged commit 06aa564 into open-telemetry:main Jan 18, 2022
@codeboten codeboten deleted the codeboten/fill-otlp-metrics-details branch January 20, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants