Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use the centralized release scripts from the toys repository #1471

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Jun 15, 2023

The copy of the release scripts currently in the repo is slightly out of date. The most up to date scripts are in the toys repository. This change removes the copy here and references the central scripts. (I'll do the same in the contrib repo.) This will pick up minor fixes that have been made to the central scripts in the past year or two, and let me make additional changes in one place and have them apply to both repositories.

Ref: open-telemetry/opentelemetry-ruby-contrib#508

Copy link
Contributor

@arielvalentin arielvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In retrospect I should have asked the question, are you planning on adding the release scripts to the toys gem itself so you are not cloning the repo?

@dazuma
Copy link
Member Author

dazuma commented Jun 16, 2023

@arielvalentin No, they're not conceptually part of the toys gem (any more than someone's gem-releasing rake tasks would be part of the core rake gem). Conceivably they could be packaged in a different gem, but I haven't looked into that.

@dazuma
Copy link
Member Author

dazuma commented Jun 21, 2023

@arielvalentin Is this okay for now? Generally, this is the way I've been handling these release scripts in the repos that use them. (e.g. here's the script for the CloudEvents Ruby SDK: https://github.com/cloudevents/sdk-ruby/blob/main/.toys/.toys.rb#L22)

@dazuma dazuma merged commit de02755 into open-telemetry:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants