Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry ETW Exporter #21

Merged
merged 13 commits into from
Mar 15, 2024

Conversation

psandana
Copy link
Contributor

@psandana psandana commented Jan 3, 2024

Fixes #15
Design discussion issue (if applicable)

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable) (Note: Partially added coverage for ~60%)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable) (Note: New code, New API)

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: Patch coverage is 59.66543% with 217 lines in your changes are missing coverage. Please review.

Project coverage is 51.9%. Comparing base (eb0422a) to head (90fbf66).

Files Patch % Lines
opentelemetry-etw-logs/src/logs/exporter.rs 31.2% 207 Missing ⚠️
...emetry-etw-logs/src/logs/reentrant_logprocessor.rs 86.7% 9 Missing ⚠️
opentelemetry-etw-logs/src/logs/converters.rs 99.4% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #21     +/-   ##
=======================================
+ Coverage   51.0%   51.9%   +0.9%     
=======================================
  Files         34      37      +3     
  Lines       4358    4896    +538     
=======================================
+ Hits        2223    2544    +321     
- Misses      2135    2352    +217     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hdost hdost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to make sure we have some windows testing in place for ETW
Example: https://github.com/rust-lang/rustfmt/blob/master/.github/workflows/windows.yml

@psandana psandana force-pushed the feat/opentelemetry-etw-logs branch 2 times, most recently from 79bcc39 to 541797d Compare January 19, 2024 15:49
@psandana psandana force-pushed the feat/opentelemetry-etw-logs branch from 85cf5ea to 652747d Compare March 13, 2024 15:16
@psandana psandana force-pushed the feat/opentelemetry-etw-logs branch from 7c37a47 to 1018495 Compare March 14, 2024 16:46
@psandana psandana marked this pull request as ready for review March 14, 2024 19:48
@psandana psandana requested a review from a team March 14, 2024 19:48
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some non-blocking comments. It is okay to merge now and address issues as follow ups.
I tested with logman and perfview and see logs flowing to etw.
Thanks!

opentelemetry-etw-logs/Cargo.toml Outdated Show resolved Hide resolved
opentelemetry-etw-logs/Cargo.toml Outdated Show resolved Hide resolved
"registry",
"std",
] }
microbench = "0.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - Is there a particular reason we're leaning towards microbench rather than criterion, as otel-rust mainly sticks with criterion? Just curious, as it doesn’t necessarily mean we can’t explore using it here. :)

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Nicely done :)

@cijothomas cijothomas merged commit a98f9be into open-telemetry:main Mar 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ETW Exporter for logs
4 participants