Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs API] Remove global provider for Logs #1691

Merged
merged 13 commits into from
Apr 30, 2024
Merged

[Logs API] Remove global provider for Logs #1691

merged 13 commits into from
Apr 30, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Apr 30, 2024 •
edited
Loading

Changes

As discussed here - LoggerProviders are not meant for end users to get loggers from. It is only required for the log bridges.
So removing all the global constructs for the logs i.e -
opentelemetry::global::logger
opentelemetry::global::set_logger_provider
opentelemetry:global::shutdown_logger_provider
opentelemetry::global::logger_provider
opentelemetry::global::GlobalLoggerProvider
opentelemetry::global::ObjectSafeLoggerProvider

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team April 30, 2024 07:18
@lalitb lalitb changed the title Remove global providers for Logs Remove global provider for Logs Apr 30, 2024
@lalitb lalitb changed the title Remove global provider for Logs [Logs API] Remove global provider for Logs Apr 30, 2024
cijothomas
cijothomas approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reducing public API surface!
This should significantly help us achieve the release goals!

TommyCpp
TommyCpp approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One nit, feel free to ignore if you don't agree.

opentelemetry-otlp/examples/basic-otlp-http/src/main.rs Show resolved Hide resolved
@lalitb @TommyCpp
Update opentelemetry-otlp/examples/basic-otlp-http/src/main.rs
c11994a 
Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
@cijothomas cijothomas merged commit 213fa3f into open-telemetry:main Apr 30, 2024
15 checks passed
@lalitb lalitb mentioned this pull request May 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TommyCpp TommyCpp TommyCpp approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lalitb @cijothomas @TommyCpp